-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sharded] use internal indexer ledger version in API context and add state indices restore #13883
Conversation
why? doesn't seem any harm to keep these checks? |
The API will constantly error out. The main use of the internal indexer are by these APIs https://github.com/aptos-labs/aptos-core/blob/internal_indexer_pruner/api/src/transactions.rs#L982. We should just return the latest version the internal indexer has https://aptos-org.slack.com/archives/C03N83P7QUC/p1719867754704079?thread_ts=1719867622.533329&cid=C03N83P7QUC |
a9c9677
to
8b7dd2d
Compare
ba05c27
to
2616aa9
Compare
2616aa9
to
d96bfde
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d96bfde
to
d4f0141
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
441c7e9
to
f144bf0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f144bf0
to
127356e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
127356e
to
26a2863
Compare
26a2863
to
e8b3e6b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Description
We should return the latest we get in the internal indexer even if there is a delay between the internal indexer and node main db.
For the delay between the internal indexer and main db, we will measure the gap in different scenarios and then decide when we should alert users of the delay.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
** curl localhost:8080/v1/accounts/0x1/resources
** curl localhost:8080/v1/accounts/0x1/transactions
** curl localhost:8080/v1/accounts/0x1/events/0
** panic happens as expected
** can handle hole created by fast sync
Key Areas to Review
Checklist