Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump forge version for 1.15 branch cut #13783

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

sherry-x
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@sherry-x sherry-x requested a review from a team as a code owner June 21, 2024 16:38
Copy link

trunk-io bot commented Jun 21, 2024

⏱️ 3h 43m total CI duration on this PR
Job Cumulative Duration Recent Runs
test-fuzzers 1h 9m 🟩🟩
rust-smoke-tests 40m 🟩
forge-e2e-test / forge 13m 🟩
rust-lints 13m 🟩
forge-compat-test / forge 13m 🟩
rust-images / rust-all 11m 🟩
rust-move-tests 10m 🟩
rust-targeted-unit-tests 10m 🟩
run-tests-main-branch 9m 🟩
rust-build-cached-packages 8m 🟩
cli-e2e-tests / run-cli-tests 6m 🟩
test-target-determinator 5m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
general-lints 3m 🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 1m 🟩
check-dynamic-deps 1m 🟩🟩
semgrep/ci 47s 🟩🟩
file_change_determinator 23s 🟩🟩
file_change_determinator 18s 🟩🟩
determine-test-metadata 16s 🟥
file_change_determinator 10s 🟩
execution-performance / single-node-performance 8s 🟩
permission-check 6s 🟩🟩
permission-check 6s 🟩🟩
forge-framework-upgrade-test / forge 6s 🟩
permission-check 5s 🟩🟩
permission-check 4s 🟩🟩
permission-check 3s 🟩
determine-docker-build-metadata 2s 🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-lints 10m 6m +65%
rust-build-cached-packages 8m 5m +60%
forge-framework-upgrade-test / forge 6s 14m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@sherry-x sherry-x requested review from ibalajiarun, perryjrandall, junkil-park and igor-aptos and removed request for a team June 21, 2024 16:38
@sherry-x sherry-x enabled auto-merge (squash) June 21, 2024 16:45

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on a68e71c05caebf01504d4499110f3fba213fb53d ==> dc5ec7451e01b75df34d2c48ef85df2db4ce9416

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> dc5ec7451e01b75df34d2c48ef85df2db4ce9416 (PR)
1. Check liveness of validators at old version: a68e71c05caebf01504d4499110f3fba213fb53d
compatibility::simple-validator-upgrade::liveness-check : committed: 7067.8476715037095 txn/s, latency: 3773.8946891685737 ms, (p50: 2900 ms, p90: 5100 ms, p99: 22900 ms), latency samples: 314640
2. Upgrading first Validator to new version: dc5ec7451e01b75df34d2c48ef85df2db4ce9416
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2516.4973829757655 txn/s, latency: 12283.528006059458 ms, (p50: 14000 ms, p90: 15300 ms, p99: 17500 ms), latency samples: 105620
3. Upgrading rest of first batch to new version: dc5ec7451e01b75df34d2c48ef85df2db4ce9416
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3318.8462650715255 txn/s, latency: 9340.203912295787 ms, (p50: 9400 ms, p90: 14200 ms, p99: 14500 ms), latency samples: 139560
4. upgrading second batch to new version: dc5ec7451e01b75df34d2c48ef85df2db4ce9416
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 4888.653062194931 txn/s, latency: 6603.484765451311 ms, (p50: 5500 ms, p90: 13800 ms, p99: 18800 ms), latency samples: 179920
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> dc5ec7451e01b75df34d2c48ef85df2db4ce9416 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on dc5ec7451e01b75df34d2c48ef85df2db4ce9416

two traffics test: inner traffic : committed: 8694.04162186885 txn/s, latency: 4507.99430666965 ms, (p50: 4400 ms, p90: 5400 ms, p99: 9300 ms), latency samples: 3754920
two traffics test : committed: 99.91151202179202 txn/s, latency: 1992.6333333333334 ms, (p50: 1900 ms, p90: 2200 ms, p99: 3700 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.214, avg: 0.209", "QsPosToProposal: max: 0.269, avg: 0.247", "ConsensusProposalToOrdered: max: 0.301, avg: 0.287", "ConsensusOrderedToCommit: max: 0.375, avg: 0.364", "ConsensusProposalToCommit: max: 0.659, avg: 0.651"]
Max round gap was 1 [limit 4] at version 1711231. Max no progress secs was 4.937919 [limit 15] at version 1711231.
Test Ok

@sherry-x sherry-x merged commit 437be63 into aptos-labs:main Jun 21, 2024
99 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants