Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Revert changes made to override stdlib version #13756

Closed
wants to merge 2 commits into from

Conversation

fEst1ck
Copy link
Contributor

@fEst1ck fEst1ck commented Jun 19, 2024

Description

Revert changes made in #13318 that's blocking CI tests.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

Copy link

trunk-io bot commented Jun 19, 2024

⏱️ 6h 18m total CI duration on this PR
Job Cumulative Duration Recent Runs
test-fuzzers 1h 10m 🟩🟩
rust-targeted-unit-tests 1h 4m 🟥🟩🟩
execution-performance / single-node-performance 54m 🟥🟩
rust-smoke-tests 33m 🟩
forge-e2e-test / forge 28m 🟥🟩
rust-move-tests 23m 🟩🟩
rust-images / rust-all 18m 🟩
forge-framework-upgrade-test / forge 16m 🟩
forge-compat-test / forge 13m 🟩
rust-lints 11m 🟩🟩
rust-move-unit-coverage 11m 🟩
run-tests-main-branch 9m 🟩🟩
cli-e2e-tests / run-cli-tests 6m 🟩
rust-build-cached-packages 4m 🟩
check 4m 🟩
execution-performance / test-target-determinator 4m 🟩
test-target-determinator 4m 🟩
general-lints 4m 🟩🟩
check-dynamic-deps 1m 🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 1m 🟩
semgrep/ci 37s 🟩🟩
file_change_determinator 22s 🟩🟩
file_change_determinator 20s 🟩🟩
file_change_determinator 11s 🟩
permission-check 10s 🟩🟩
permission-check 5s 🟩🟩
permission-check 5s 🟩🟩
permission-check 5s 🟩🟩
determine-docker-build-metadata 4s 🟩
permission-check 2s 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 28m 13m +119%
rust-images / rust-all 18m 14m +28%

settingsfeedbackdocs ⋅ learn more about trunk.io

@fEst1ck fEst1ck enabled auto-merge (squash) June 19, 2024 02:44

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on a68e71c05caebf01504d4499110f3fba213fb53d ==> fa105c8223e915d66be3eeb9b51af5e368d06bda

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> fa105c8223e915d66be3eeb9b51af5e368d06bda (PR)
1. Check liveness of validators at old version: a68e71c05caebf01504d4499110f3fba213fb53d
compatibility::simple-validator-upgrade::liveness-check : committed: 8738.847765760167 txn/s, latency: 3773.4476982873803 ms, (p50: 2700 ms, p90: 6300 ms, p99: 29300 ms), latency samples: 329320
2. Upgrading first Validator to new version: fa105c8223e915d66be3eeb9b51af5e368d06bda
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3320.6661128119736 txn/s, latency: 9310.966578230316 ms, (p50: 9400 ms, p90: 14200 ms, p99: 14500 ms), latency samples: 139460
3. Upgrading rest of first batch to new version: fa105c8223e915d66be3eeb9b51af5e368d06bda
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3342.3162554343808 txn/s, latency: 9354.573019334206 ms, (p50: 9400 ms, p90: 14100 ms, p99: 14300 ms), latency samples: 137580
4. upgrading second batch to new version: fa105c8223e915d66be3eeb9b51af5e368d06bda
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6355.849322505548 txn/s, latency: 5105.755132212554 ms, (p50: 4900 ms, p90: 8400 ms, p99: 9500 ms), latency samples: 236740
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> fa105c8223e915d66be3eeb9b51af5e368d06bda passed
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite framework_upgrade success on a68e71c05caebf01504d4499110f3fba213fb53d ==> fa105c8223e915d66be3eeb9b51af5e368d06bda

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> fa105c8223e915d66be3eeb9b51af5e368d06bda (PR)
Upgrade the nodes to version: fa105c8223e915d66be3eeb9b51af5e368d06bda
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1152.5530268349582 txn/s, submitted: 1154.516861981023 txn/s, failed submission: 1.9638351460648662 txn/s, expired: 1.9638351460648662 txn/s, latency: 2681.121544869368 ms, (p50: 2100 ms, p90: 4500 ms, p99: 8100 ms), latency samples: 105640
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1054.4484760628266 txn/s, submitted: 1057.8794363970874 txn/s, failed submission: 3.4309603342608237 txn/s, expired: 3.4309603342608237 txn/s, latency: 2897.3419414316704 ms, (p50: 2100 ms, p90: 5100 ms, p99: 9300 ms), latency samples: 92200
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> fa105c8223e915d66be3eeb9b51af5e368d06bda passed
Upgrade the remaining nodes to version: fa105c8223e915d66be3eeb9b51af5e368d06bda
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1169.257444485777 txn/s, submitted: 1172.3689450033212 txn/s, failed submission: 3.1115005175443597 txn/s, expired: 3.1115005175443597 txn/s, latency: 2627.7478806310587 ms, (p50: 2100 ms, p90: 4500 ms, p99: 8100 ms), latency samples: 105220
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on fa105c8223e915d66be3eeb9b51af5e368d06bda

two traffics test: inner traffic : committed: 8617.48521627516 txn/s, latency: 4548.1676106541745 ms, (p50: 4400 ms, p90: 5400 ms, p99: 9600 ms), latency samples: 3722860
two traffics test : committed: 99.99705475544364 txn/s, latency: 2174.773888888889 ms, (p50: 2000 ms, p90: 2400 ms, p99: 6700 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.232, avg: 0.216", "QsPosToProposal: max: 0.257, avg: 0.244", "ConsensusProposalToOrdered: max: 0.322, avg: 0.291", "ConsensusOrderedToCommit: max: 0.374, avg: 0.358", "ConsensusProposalToCommit: max: 0.664, avg: 0.649"]
Max round gap was 1 [limit 4] at version 1823812. Max no progress secs was 5.128536 [limit 15] at version 1823812.
Test Ok

@wrwg wrwg self-requested a review June 19, 2024 20:21
@brmataptos
Copy link
Contributor

You need to also delete third_party/move/tools/move-package/src/source_package/std_lib.rs and reference to it in third_party/move/tools/move-package/src/source_package/mod.rs. Did you not use git revert to produce this PR?

@fEst1ck fEst1ck closed this Jun 20, 2024
auto-merge was automatically disabled June 20, 2024 05:57

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants