[compiler] Filter out spec blocks of filtered module members #13741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #13696. This removes, in the generic parser AST filter, spec blocks for members which are filtered out. For example, for a `#[test_only]` function which is filtered out, also an associated spec block will be removed. This works equally for other attributes like `#[verify_only]` thanks to the generic filter logic.
⏱️ 1h 40m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13741 +/- ##
===========================================
- Coverage 70.7% 58.9% -11.9%
===========================================
Files 2298 817 -1481
Lines 451858 195849 -256009
===========================================
- Hits 319816 115399 -204417
+ Misses 132042 80450 -51592 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #13696. This removes, in the generic parser AST filter, spec blocks for members which are filtered out. For example, for a
#[test_only]function which is filtered out, also an associated spec block will be removed. This works equally for other attributes like#[verify_only]thanks to the generic filter logic.Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Test TBD