Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forge] Increase PFN const TPS test. #13712

Closed
wants to merge 1 commit into from
Closed

[Forge] Increase PFN const TPS test. #13712

wants to merge 1 commit into from

Conversation

JoshLind
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jun 14, 2024

⏱️ 4h 55m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-smoke-tests 1h 7m 🟩🟩
adhoc-forge-test / forge 46m 🟥🟥
forge-e2e-test / forge 28m 🟩🟩
rust-images / rust-all 26m 🟩🟩
forge-compat-test / forge 25m 🟩🟩
rust-targeted-unit-tests 15m 🟩🟩
cli-e2e-tests / run-cli-tests 11m 🟩🟩
rust-lints 11m 🟩🟩
run-tests-main-branch 10m 🟩🟩
rust-move-tests 10m 🟩🟩
check 8m 🟩🟩
rust-build-cached-packages 8m 🟩🟩
execution-performance / test-target-determinator 7m 🟩🟩
test-target-determinator 7m 🟩🟩
general-lints 4m 🟩🟩
check-dynamic-deps 4m 🟩🟩🟩
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 3m 🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 2m 🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 27s 🟩🟩
file_change_determinator 22s 🟩🟩
file_change_determinator 20s 🟩🟩
execution-performance / single-node-performance 14s 🟩🟩
permission-check 10s 🟩🟩🟩
determine-forge-run-metadata 9s 🟩🟩
permission-check 9s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 6s 🟩🟩🟩
permission-check 4s 🟩🟩
determine-docker-build-metadata 4s 🟩🟩

🚨 5 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
run-tests-main-branch 6m 5m +29%
rust-build-cached-packages 4m 5m -22%
rust-targeted-unit-tests 8m 16m -51%
rust-move-tests 3m 9m -67%
execution-performance / single-node-performance 7s 16m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@JoshLind JoshLind added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Jun 14, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on a68e71c05caebf01504d4499110f3fba213fb53d ==> e3ab21cb400866c851dfd773f3ea27c1fcb53cd3

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> e3ab21cb400866c851dfd773f3ea27c1fcb53cd3 (PR)
1. Check liveness of validators at old version: a68e71c05caebf01504d4499110f3fba213fb53d
compatibility::simple-validator-upgrade::liveness-check : committed: 9589.498157871989 txn/s, latency: 3489.2138535031845 ms, (p50: 2600 ms, p90: 6300 ms, p99: 25600 ms), latency samples: 364240
2. Upgrading first Validator to new version: e3ab21cb400866c851dfd773f3ea27c1fcb53cd3
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3309.9852418750056 txn/s, latency: 9285.205038145963 ms, (p50: 9100 ms, p90: 14200 ms, p99: 14600 ms), latency samples: 138940
3. Upgrading rest of first batch to new version: e3ab21cb400866c851dfd773f3ea27c1fcb53cd3
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3319.315903610802 txn/s, latency: 9369.870153757724 ms, (p50: 9400 ms, p90: 14300 ms, p99: 14500 ms), latency samples: 139180
4. upgrading second batch to new version: e3ab21cb400866c851dfd773f3ea27c1fcb53cd3
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6442.486883796508 txn/s, latency: 5095.640582766635 ms, (p50: 4800 ms, p90: 8200 ms, p99: 9300 ms), latency samples: 232340
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> e3ab21cb400866c851dfd773f3ea27c1fcb53cd3 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on e3ab21cb400866c851dfd773f3ea27c1fcb53cd3

two traffics test: inner traffic : committed: 8697.242170875053 txn/s, latency: 4468.6958295831955 ms, (p50: 4200 ms, p90: 5400 ms, p99: 9900 ms), latency samples: 3799860
two traffics test : committed: 99.91691883677315 txn/s, latency: 1912.4247252747252 ms, (p50: 1900 ms, p90: 2200 ms, p99: 3100 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.224, avg: 0.208", "QsPosToProposal: max: 0.247, avg: 0.238", "ConsensusProposalToOrdered: max: 0.316, avg: 0.284", "ConsensusOrderedToCommit: max: 0.362, avg: 0.348", "ConsensusProposalToCommit: max: 0.643, avg: 0.632"]
Max round gap was 1 [limit 4] at version 1906765. Max no progress secs was 5.046659 [limit 15] at version 1906765.
Test Ok

@JoshLind JoshLind closed this Jun 26, 2024
@JoshLind JoshLind deleted the pfn_baseline branch June 26, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant