Check epoch in verify_order_vote_proposal

[vusirikala]

Description

Add a check to verify epoch in order vote safety rules.

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 3h 46m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
test-fuzzers	34m	🟩
rust-smoke-tests	34m	🟩
forge-e2e-test / forge	26m	🟥 🟩
rust-targeted-unit-tests	22m	🟥 🟩
forge-framework-upgrade-test / forge	18m	🟩
rust-move-tests	13m	🟩 🟩
forge-compat-test / forge	13m	🟩
rust-images / rust-all	13m	🟩
rust-lints	11m	🟩 🟩
run-tests-main-branch	9m	🟩 🟩
cli-e2e-tests / run-cli-tests	7m	🟩
general-lints	5m	🟩 🟩
rust-build-cached-packages	4m	🟩
check	4m	🟩
test-target-determinator	3m	🟩
execution-performance / test-target-determinator	3m	🟩
check-dynamic-deps	2m	🟩 🟩
node-api-compatibility-tests / node-api-compatibility-tests	1m	🟩
semgrep/ci	46s	🟩 🟩
file_change_determinator	21s	🟩 🟩
file_change_determinator	21s	🟩 🟩
permission-check	9s	🟩
file_change_determinator	9s	🟩
permission-check	9s	🟩 🟩
permission-check	9s	🟩 🟩
execution-performance / single-node-performance	7s	🟩
permission-check	5s	🟩 🟩
permission-check	4s	🟩 🟩
determine-docker-build-metadata	2s	🟩

🚨 4 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
forge-framework-upgrade-test / forge	18m	11m
general-lints	3m	2m
execution-performance / test-target-determinator	3m	4m
execution-performance / single-node-performance	7s	13m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite compat success on a68e71c05caebf01504d4499110f3fba213fb53d ==> c6ec775e5a80969937e8ca0b26403136e9745535

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> c6ec775e5a80969937e8ca0b26403136e9745535 (PR)
1. Check liveness of validators at old version: a68e71c05caebf01504d4499110f3fba213fb53d
compatibility::simple-validator-upgrade::liveness-check : committed: 9117.662202059735 txn/s, latency: 3161.4336234652114 ms, (p50: 2700 ms, p90: 4800 ms, p99: 13800 ms), latency samples: 366500
2. Upgrading first Validator to new version: c6ec775e5a80969937e8ca0b26403136e9745535
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3365.8528659752806 txn/s, latency: 9267.728647607762 ms, (p50: 9900 ms, p90: 13800 ms, p99: 14200 ms), latency samples: 135020
3. Upgrading rest of first batch to new version: c6ec775e5a80969937e8ca0b26403136e9745535
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3458.6429524019204 txn/s, latency: 8991.859508315256 ms, (p50: 10000 ms, p90: 12900 ms, p99: 13600 ms), latency samples: 138300
4. upgrading second batch to new version: c6ec775e5a80969937e8ca0b26403136e9745535
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6377.153993084673 txn/s, latency: 5137.598444387928 ms, (p50: 4800 ms, p90: 8400 ms, p99: 9500 ms), latency samples: 235920
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> c6ec775e5a80969937e8ca0b26403136e9745535 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on a68e71c05caebf01504d4499110f3fba213fb53d ==> c6ec775e5a80969937e8ca0b26403136e9745535

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> c6ec775e5a80969937e8ca0b26403136e9745535 (PR)
Upgrade the nodes to version: c6ec775e5a80969937e8ca0b26403136e9745535
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1236.7459611006914 txn/s, submitted: 1238.7875446755093 txn/s, failed submission: 2.0415835748177225 txn/s, expired: 2.0415835748177225 txn/s, latency: 2668.0787692589874 ms, (p50: 1800 ms, p90: 4800 ms, p99: 8700 ms), latency samples: 109040
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1148.5710074665476 txn/s, submitted: 1152.34263333615 txn/s, failed submission: 3.7716258696023393 txn/s, expired: 3.7716258696023393 txn/s, latency: 2502.425294572146 ms, (p50: 1800 ms, p90: 4500 ms, p99: 9100 ms), latency samples: 103540
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> c6ec775e5a80969937e8ca0b26403136e9745535 passed
Upgrade the remaining nodes to version: c6ec775e5a80969937e8ca0b26403136e9745535
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1182.697936142125 txn/s, submitted: 1184.7127537505442 txn/s, failed submission: 2.014817608419293 txn/s, expired: 2.014817608419293 txn/s, latency: 2605.112852545902 ms, (p50: 2000 ms, p90: 4800 ms, p99: 8400 ms), latency samples: 105660
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on c6ec775e5a80969937e8ca0b26403136e9745535

two traffics test: inner traffic : committed: 8776.588972093881 txn/s, latency: 4471.589494539633 ms, (p50: 4500 ms, p90: 5100 ms, p99: 9900 ms), latency samples: 3785460
two traffics test : committed: 100.05096133189319 txn/s, latency: 1954.483870967742 ms, (p50: 1900 ms, p90: 2100 ms, p99: 3100 ms), latency samples: 1860
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.209, avg: 0.205", "QsPosToProposal: max: 0.252, avg: 0.237", "ConsensusProposalToOrdered: max: 0.301, avg: 0.284", "ConsensusOrderedToCommit: max: 0.356, avg: 0.346", "ConsensusProposalToCommit: max: 0.639, avg: 0.629"]
Max round gap was 1 [limit 4] at version 1878940. Max no progress secs was 4.982906 [limit 15] at version 1878940.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking