Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Terraform & Helm #13655

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Sync Terraform & Helm #13655

merged 1 commit into from
Jul 20, 2024

Conversation

aptos-bot
Copy link
Contributor

Sync Terraform & Helm changes

Copy link

trunk-io bot commented Jun 12, 2024

⏱️ 52m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-lints 19m 🟩🟩
rust-move-tests 10m 🟩🟩
run-tests-main-branch 9m 🟩🟩
rust-targeted-unit-tests 6m 🟩🟩
general-lints 4m 🟩🟩
check-dynamic-deps 3m 🟩🟩
semgrep/ci 47s 🟩🟩
file_change_determinator 24s 🟩🟩
file_change_determinator 19s 🟩🟩
permission-check 7s 🟩🟩
permission-check 6s 🟩🟩
permission-check 6s 🟩🟩
permission-check 5s 🟩🟩
check-terraform-modifications 2s 🟥🟥

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-lints 13m 7m +80%
rust-targeted-unit-tests 3m 17m -82%

settingsfeedbackdocs ⋅ learn more about trunk.io

GitOrigin-RevId: 0ee63a1936abd488fd236589033cfec1ce396214
@sionescu sionescu marked this pull request as ready for review July 19, 2024 22:02
@sionescu sionescu requested a review from a team as a code owner July 19, 2024 22:02
@sionescu sionescu requested a review from sherry-x July 19, 2024 22:03
@sionescu sionescu enabled auto-merge (rebase) July 20, 2024 01:18
@sionescu sionescu added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Jul 20, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 96587f026ed8803aa4380ca6e768a77acd18f693

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 96587f026ed8803aa4380ca6e768a77acd18f693 (PR)
1. Check liveness of validators at old version: 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5
compatibility::simple-validator-upgrade::liveness-check : committed: 6519.531542247269 txn/s, latency: 4484.2662315511 ms, (p50: 3400 ms, p90: 6100 ms, p99: 27000 ms), latency samples: 287280
2. Upgrading first Validator to new version: 96587f026ed8803aa4380ca6e768a77acd18f693
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6727.863466420778 txn/s, latency: 3855.1744054696787 ms, (p50: 3800 ms, p90: 5700 ms, p99: 5800 ms), latency samples: 134560
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6853.736300201786 txn/s, latency: 4464.618986133023 ms, (p50: 4100 ms, p90: 6800 ms, p99: 7500 ms), latency samples: 240860
3. Upgrading rest of first batch to new version: 96587f026ed8803aa4380ca6e768a77acd18f693
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6100.671372881238 txn/s, latency: 4233.713031066331 ms, (p50: 4400 ms, p90: 5700 ms, p99: 5900 ms), latency samples: 119100
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6662.677388675613 txn/s, latency: 4645.530567967005 ms, (p50: 4500 ms, p90: 7100 ms, p99: 7400 ms), latency samples: 232760
4. upgrading second batch to new version: 96587f026ed8803aa4380ca6e768a77acd18f693
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10027.973873783085 txn/s, latency: 2903.8724478019094 ms, (p50: 3000 ms, p90: 3900 ms, p99: 4900 ms), latency samples: 190620
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8133.428508734429 txn/s, latency: 4104.697658954272 ms, (p50: 3600 ms, p90: 5600 ms, p99: 11800 ms), latency samples: 329340
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 96587f026ed8803aa4380ca6e768a77acd18f693 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 96587f026ed8803aa4380ca6e768a77acd18f693

two traffics test: inner traffic : committed: 9340.38996772932 txn/s, submitted: 9475.837983536625 txn/s, failed submission: 4.523700722108022 txn/s, expired: 135.44801580730416 txn/s, latency: 8700.403051191079 ms, (p50: 7800 ms, p90: 14500 ms, p99: 27900 ms), latency samples: 3551400
two traffics test : committed: 99.99409811472994 txn/s, latency: 1861.1816831683168 ms, (p50: 2000 ms, p90: 2200 ms, p99: 2600 ms), latency samples: 2020
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.244, avg: 0.217", "QsPosToProposal: max: 1.538, avg: 1.122", "ConsensusProposalToOrdered: max: 0.318, avg: 0.295", "ConsensusOrderedToCommit: max: 0.408, avg: 0.387", "ConsensusProposalToCommit: max: 0.700, avg: 0.682"]
Max round gap was 1 [limit 4] at version 1529394. Max no progress secs was 5.994866 [limit 15] at version 1529394.
Test Ok

@sionescu sionescu merged commit 8e510c6 into main Jul 20, 2024
126 of 140 checks passed
@sionescu sionescu deleted the sync_terraform_helm branch July 20, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants