Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip bn254 verification in vk update in main #13540

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Jun 4, 2024

cherry-picking #13504

Copy link

trunk-io bot commented Jun 4, 2024

@zjma zjma changed the title skip vk vrfy skip bn254 verification in vk update in main Jun 4, 2024
@zjma zjma marked this pull request as ready for review June 4, 2024 00:34
@zjma zjma enabled auto-merge (squash) June 4, 2024 00:34
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.4%. Comparing base (04db082) to head (674cf84).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13540   +/-   ##
=======================================
  Coverage    58.4%    58.4%           
=======================================
  Files         821      821           
  Lines      197406   197406           
=======================================
  Hits       115410   115410           
  Misses      81996    81996           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

✅ Forge suite compat success on a68e71c05caebf01504d4499110f3fba213fb53d ==> 674cf8449753a4ba333291337f8db8e14e5d79fe

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> 674cf8449753a4ba333291337f8db8e14e5d79fe (PR)
1. Check liveness of validators at old version: a68e71c05caebf01504d4499110f3fba213fb53d
compatibility::simple-validator-upgrade::liveness-check : committed: 6252.423899174225 txn/s, latency: 5335.247438599707 ms, (p50: 5400 ms, p90: 8100 ms, p99: 9000 ms), latency samples: 218240
2. Upgrading first Validator to new version: 674cf8449753a4ba333291337f8db8e14e5d79fe
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3344.35928844501 txn/s, latency: 9301.343750898892 ms, (p50: 9300 ms, p90: 14000 ms, p99: 14300 ms), latency samples: 139060
3. Upgrading rest of first batch to new version: 674cf8449753a4ba333291337f8db8e14e5d79fe
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3304.941288429178 txn/s, latency: 9398.204921404436 ms, (p50: 9400 ms, p90: 14100 ms, p99: 14500 ms), latency samples: 136140
4. upgrading second batch to new version: 674cf8449753a4ba333291337f8db8e14e5d79fe
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6489.69440902576 txn/s, latency: 5079.299638180565 ms, (p50: 4800 ms, p90: 8300 ms, p99: 9300 ms), latency samples: 232160
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> 674cf8449753a4ba333291337f8db8e14e5d79fe passed
Test Ok

Copy link
Contributor

github-actions bot commented Jun 4, 2024

✅ Forge suite realistic_env_max_load success on 674cf8449753a4ba333291337f8db8e14e5d79fe

two traffics test: inner traffic : committed: 8572.980519205254 txn/s, latency: 4574.624137511754 ms, (p50: 4500 ms, p90: 5400 ms, p99: 9800 ms), latency samples: 3700920
two traffics test : committed: 99.95007211945558 txn/s, latency: 2065.679775280899 ms, (p50: 2000 ms, p90: 2300 ms, p99: 6000 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.214, avg: 0.204", "QsPosToProposal: max: 0.207, avg: 0.197", "ConsensusProposalToOrdered: max: 0.412, avg: 0.371", "ConsensusOrderedToCommit: max: 0.362, avg: 0.351", "ConsensusProposalToCommit: max: 0.733, avg: 0.722"]
Max round gap was 1 [limit 4] at version 1721017. Max no progress secs was 5.050384 [limit 15] at version 1721017.
Test Ok

Copy link
Contributor

github-actions bot commented Jun 4, 2024

✅ Forge suite framework_upgrade success on a68e71c05caebf01504d4499110f3fba213fb53d ==> 674cf8449753a4ba333291337f8db8e14e5d79fe

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> 674cf8449753a4ba333291337f8db8e14e5d79fe (PR)
Upgrade the nodes to version: 674cf8449753a4ba333291337f8db8e14e5d79fe
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1044.6192619461435 txn/s, submitted: 1046.8618966862598 txn/s, failed submission: 2.2426347401162374 txn/s, expired: 2.2426347401162374 txn/s, latency: 2990.757299270073 ms, (p50: 2400 ms, p90: 5200 ms, p99: 8100 ms), latency samples: 93160
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1009.0824514550696 txn/s, submitted: 1009.7396914364776 txn/s, failed submission: 0.6572399814079914 txn/s, expired: 0.6572399814079914 txn/s, latency: 2959.365686061659 ms, (p50: 2100 ms, p90: 5700 ms, p99: 9300 ms), latency samples: 92120
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> 674cf8449753a4ba333291337f8db8e14e5d79fe passed
Upgrade the remaining nodes to version: 674cf8449753a4ba333291337f8db8e14e5d79fe
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1118.3868519939676 txn/s, submitted: 1121.1631536538616 txn/s, failed submission: 2.776301659894003 txn/s, expired: 2.776301659894003 txn/s, latency: 3064.796659081506 ms, (p50: 2100 ms, p90: 6100 ms, p99: 9600 ms), latency samples: 96680
Test Ok

@zjma zjma merged commit beab1a5 into main Jun 4, 2024
82 of 85 checks passed
@zjma zjma deleted the zjma/skip_vk_vrfy_main branch June 4, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants