Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] bump version to 3.3.1 #13373

Merged
merged 1 commit into from
May 21, 2024
Merged

[cli] bump version to 3.3.1 #13373

merged 1 commit into from
May 21, 2024

Conversation

vgao1996
Copy link
Contributor

Description

This bumps the CLI version to 3.3.1, so that we can make another CLI release to fix local simulation and gas profiling.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Manually ran replay command

cargo run -p aptos -- move replay --network testnet --txn-id 1199201215

Key Areas to Review

N/A

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@vgao1996 vgao1996 requested a review from vineethk May 21, 2024 19:44
Copy link

trunk-io bot commented May 21, 2024

⏱️ 4h 11m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 48m 🟩
rust-smoke-tests 35m 🟩
cli-e2e-tests / run-cli-tests 28m 🟥🟥
forge-e2e-test / forge 20m 🟥🟩
rust-targeted-unit-tests 20m 🟩
forge-framework-upgrade-test / forge 16m 🟩
rust-images / rust-all 13m 🟩
forge-compat-test / forge 13m 🟩
rust-lints 12m 🟩🟩
rust-move-tests 11m 🟩🟩
run-tests-main-branch 8m 🟩🟩
rust-build-cached-packages 4m 🟩
check-dynamic-deps 4m 🟩🟩
test-target-determinator 4m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
general-lints 3m 🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 51s 🟩
semgrep/ci 44s 🟩🟩
file_change_determinator 22s 🟩🟩
file_change_determinator 21s 🟩🟩
file_change_determinator 13s 🟩
execution-performance / single-node-performance 7s 🟩
permission-check 6s 🟩🟩
permission-check 5s 🟩🟩
permission-check 5s 🟩🟩
permission-check 4s 🟩🟩
permission-check 2s 🟩
determine-docker-build-metadata 2s 🟩
🚨 7 jobs on the last run were significantly faster/slower than expected
Job Duration vs 7d avg Delta
check-dynamic-deps 3m 1m +120%
cli-e2e-tests / run-cli-tests 11m 7m +65%
windows-build 48m 38m +27%
rust-targeted-unit-tests 10m 19m -46%
rust-move-tests 3m 9m -65%
forge-framework-upgrade-test / forge 16m 53m -70%
execution-performance / single-node-performance 7s 22m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@vineethk vineethk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vgao1996 vgao1996 enabled auto-merge (squash) May 21, 2024 19:54

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 57eca7969062b371c2ce7ad67854b77467227613

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 57eca7969062b371c2ce7ad67854b77467227613 (PR)
1. Check liveness of validators at old version: 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411
compatibility::simple-validator-upgrade::liveness-check : committed: 6638.981907206765 txn/s, latency: 4909.764171703084 ms, (p50: 4800 ms, p90: 7800 ms, p99: 8700 ms), latency samples: 258120
2. Upgrading first Validator to new version: 57eca7969062b371c2ce7ad67854b77467227613
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1638.6878747056417 txn/s, latency: 17409.301521004345 ms, (p50: 20300 ms, p90: 22200 ms, p99: 24300 ms), latency samples: 82840
3. Upgrading rest of first batch to new version: 57eca7969062b371c2ce7ad67854b77467227613
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1847.907621684693 txn/s, latency: 15433.169349945829 ms, (p50: 19200 ms, p90: 21700 ms, p99: 22200 ms), latency samples: 92300
4. upgrading second batch to new version: 57eca7969062b371c2ce7ad67854b77467227613
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3583.559363691061 txn/s, latency: 8711.786554505006 ms, (p50: 9800 ms, p90: 12400 ms, p99: 12600 ms), latency samples: 143840
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 57eca7969062b371c2ce7ad67854b77467227613 passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 57eca7969062b371c2ce7ad67854b77467227613

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 57eca7969062b371c2ce7ad67854b77467227613 (PR)
Upgrade the nodes to version: 57eca7969062b371c2ce7ad67854b77467227613
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1175.003255343555 txn/s, submitted: 1176.5400682709476 txn/s, failed submission: 1.5368129273925422 txn/s, expired: 1.5368129273925422 txn/s, latency: 2540.191264947683 ms, (p50: 2100 ms, p90: 4500 ms, p99: 6600 ms), latency samples: 107040
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1214.2104572753437 txn/s, submitted: 1218.5081470458788 txn/s, failed submission: 4.2976897705349355 txn/s, expired: 4.2976897705349355 txn/s, latency: 2475.919299552906 ms, (p50: 2100 ms, p90: 4200 ms, p99: 6600 ms), latency samples: 107360
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 57eca7969062b371c2ce7ad67854b77467227613 passed
Upgrade the remaining nodes to version: 57eca7969062b371c2ce7ad67854b77467227613
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1128.172877894133 txn/s, submitted: 1129.7253076455108 txn/s, failed submission: 1.5524297513778123 txn/s, expired: 1.5524297513778123 txn/s, latency: 2797.957794377826 ms, (p50: 2400 ms, p90: 4500 ms, p99: 7300 ms), latency samples: 101740
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 57eca7969062b371c2ce7ad67854b77467227613

two traffics test: inner traffic : committed: 8156.604129404526 txn/s, latency: 4806.364387964686 ms, (p50: 4500 ms, p90: 5700 ms, p99: 10200 ms), latency samples: 3524960
two traffics test : committed: 99.97475644524707 txn/s, latency: 1869.250581395349 ms, (p50: 1800 ms, p90: 2100 ms, p99: 3600 ms), latency samples: 1720
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.209, avg: 0.202", "QsPosToProposal: max: 0.245, avg: 0.226", "ConsensusProposalToOrdered: max: 0.432, avg: 0.394", "ConsensusOrderedToCommit: max: 0.366, avg: 0.351", "ConsensusProposalToCommit: max: 0.760, avg: 0.745"]
Max round gap was 1 [limit 4] at version 1726096. Max no progress secs was 4.88169 [limit 15] at version 1726096.
Test Ok

@vgao1996 vgao1996 merged commit d00610f into main May 21, 2024
84 of 86 checks passed
@vgao1996 vgao1996 deleted the victor/cli-fix-gas branch May 21, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants