Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pushing to the old GCP Docker repository #12683

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

sionescu
Copy link
Contributor

Description

Stop pushing and authenticating to the old GCP Docker repository.

@sionescu sionescu requested review from a team as code owners March 26, 2024 12:08
Copy link

trunk-io bot commented Mar 26, 2024

⏱️ 70h 48m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 9h 42m 🟩🟩🟩🟩🟩 (+18 more)
windows-build 8h 59m 🟩🟩🟩🟩🟩 (+23 more)
rust-unit-tests 6h 39m 🟩🟥🟩 (+21 more)
rust-smoke-tests 4h 49m 🟩🟩🟩🟩 (+12 more)
rust-unit-coverage 4h 42m 🟩
rust-smoke-coverage 3h 48m 🟩
rust-move-tests 3h 28m 🟩🟥🟩 (+17 more)
rust-images / rust-all 2h 19m 🟩🟩🟩🟩 (+11 more)
run-tests-testnet 1h 59m 🟩🟩🟩🟩🟩 (+11 more)
run-tests-devnet 1h 58m 🟩🟩🟩🟩🟩 (+11 more)
rust-lints 1h 44m 🟩🟩🟩 (+17 more)
rust-images-performance / rust-all 1h 35m 🟩🟩 (+4 more)
check 1h 24m 🟩🟥🟩 (+18 more)
run-tests-devnet 1h 23m 🟩🟩🟩🟩🟩 (+11 more)
run-tests-testnet 1h 23m 🟩🟩🟩🟩🟩 (+11 more)
run-tests-mainnet 1h 22m 🟩🟩🟩🟩🟩 (+11 more)
rust-network-perf-smoke-test 1h 15m 🟩🟩🟩 (+5 more)
forge-e2e-test / forge 1h 12m 🟩🟩🟩🟩🟩
run-tests-main-branch 1h 12m 🟩🟩🟩🟩🟩 (+18 more)
forge-compat-test / forge 1h 9m 🟩🟩🟩🟩🟩
check-dynamic-deps 58m 🟩🟩🟩🟩🟩 (+23 more)
cli-e2e-tests / run-cli-tests 57m 🟩🟩🟩🟩🟩 (+4 more)
rust-images-consensus-only-perf-test / rust-all 51m 🟥🟥🟥 (+4 more)
run-tests-local-testnet 51m 🟥🟥🟥 (+5 more)
run-gas-calibration 51m 🟩🟩🟩 (+5 more)
general-lints 41m 🟩🟩🟩🟩 (+17 more)
rust-cryptohasher-domain-separation-check 38m 🟥🟥🟥 (+5 more)
run-python-examples 35m 🟥🟥🟥🟥🟥 (+11 more)
rust-network-perf-unit-test 32m 🟩🟩🟩 (+5 more)
run-examples 23m 🟩🟩🟩🟩🟩 (+11 more)
faucet-tests-main / run-tests-main 22m 🟥🟥🟩🟩
semgrep/ci 11m 🟩🟩🟩🟩🟩 (+22 more)
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 10m 🟩🟩🟩🟩
copy-images 8m 🟩
node-api-compatibility-tests / node-api-compatibility-tests 8m 🟩🟩🟩🟩🟩 (+4 more)
test-copy-images 6m 🟩🟩🟩🟩🟩 (+11 more)
file_change_determinator 4m 🟩🟩🟩🟩🟩 (+17 more)
file_change_determinator 4m 🟩🟩🟩🟩🟩 (+11 more)
file_change_determinator 4m 🟩🟩🟩🟩🟩 (+15 more)
execution-performance / file_change_determinator 3m 🟩🟩🟩🟩🟩 (+16 more)
permission-check 2m 🟩🟩🟩🟩🟩 (+20 more)
permission-check 2m 🟩🟩🟩🟩🟩 (+19 more)
permission-check 1m 🟩🟩🟩🟩🟩 (+15 more)
permission-check 1m 🟩🟩🟩🟩🟩 (+11 more)
permission-check 1m 🟩🟩🟩🟩🟩 (+13 more)
determine-docker-build-metadata 54s 🟩🟩🟩🟩🟩 (+11 more)
upload-to-codecov 12s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-tests 13m 17m -21%

settingsfeedbackdocs ⋅ learn more about trunk.io

@sionescu sionescu enabled auto-merge (rebase) March 26, 2024 13:58

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@sionescu sionescu force-pushed the stelian/disable-old-repo branch from 7b746e2 to 465c76d Compare March 26, 2024 17:06
@sionescu sionescu requested a review from ibalajiarun March 26, 2024 17:07

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@perryjrandall perryjrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test copy images job

@sionescu sionescu force-pushed the stelian/disable-old-repo branch from 465c76d to 7b00ca7 Compare March 26, 2024 19:13
@sionescu sionescu disabled auto-merge March 26, 2024 19:15
@sionescu sionescu added CICD:build-images when this label is present github actions will start build+push rust images from the PR. CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR CICD:run-coverage run tests with test coverage instrumentation CICD:run-consensus-only-perf-test Builds consensus-only aptos-node image and uses it to run forge CICD:build-performance-images build performance docker image variants CICD:non-required-tests If this label is present, non-required tests will be run on the PR. CICD:run-execution-performance-full-test Run execution performance test (full version) labels Mar 26, 2024
@sionescu sionescu force-pushed the stelian/disable-old-repo branch 3 times, most recently from 2ced2d5 to 28f4b5d Compare March 26, 2024 19:57
@sionescu sionescu removed CICD:non-required-tests If this label is present, non-required tests will be run on the PR. CICD:run-execution-performance-full-test Run execution performance test (full version) labels Mar 26, 2024
@sionescu sionescu force-pushed the stelian/disable-old-repo branch from 21492ed to ad470cb Compare March 26, 2024 23:20

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@sionescu sionescu disabled auto-merge March 26, 2024 23:58
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.0%. Comparing base (bdbd3b0) to head (7b00ca7).
Report is 2 commits behind head on main.

❗ Current head 7b00ca7 differs from pull request most recent head b8900ec. Consider uploading reports for the commit b8900ec to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #12683       +/-   ##
===========================================
+ Coverage    64.1%    70.0%     +5.8%     
===========================================
  Files         819     2293     +1474     
  Lines      183129   435514   +252385     
===========================================
+ Hits       117397   304872   +187475     
- Misses      65732   130642    +64910     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sionescu sionescu force-pushed the stelian/disable-old-repo branch 2 times, most recently from f93b24c to acd0bb5 Compare March 27, 2024 14:00
@sionescu sionescu enabled auto-merge (rebase) March 27, 2024 15:12

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@sionescu sionescu disabled auto-merge March 27, 2024 18:19
@sionescu sionescu force-pushed the stelian/disable-old-repo branch 2 times, most recently from 2ec1151 to 8bc73a9 Compare March 27, 2024 18:28
@sionescu sionescu enabled auto-merge (squash) March 27, 2024 18:56
Reference GCP_DOCKER_ARTIFACT_REPO as configuration variable for
better debuggability.
@sionescu sionescu force-pushed the stelian/disable-old-repo branch from 8bc73a9 to b8900ec Compare March 27, 2024 18:59

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on b8900ecf8282c6c97cbe043deaa6963533c94d8b

two traffics test: inner traffic : committed: 7742 txn/s, latency: 5060 ms, (p50: 4800 ms, p90: 6000 ms, p99: 10200 ms), latency samples: 3344880
two traffics test : committed: 100 txn/s, latency: 1905 ms, (p50: 1800 ms, p90: 2200 ms, p99: 2500 ms), latency samples: 1720
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.211, avg: 0.202", "QsPosToProposal: max: 0.268, avg: 0.245", "ConsensusProposalToOrdered: max: 0.463, avg: 0.433", "ConsensusOrderedToCommit: max: 0.347, avg: 0.333", "ConsensusProposalToCommit: max: 0.781, avg: 0.766"]
Max round gap was 1 [limit 4] at version 1449853. Max no progress secs was 4.685844 [limit 15] at version 1449853.
Test Ok

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> b8900ecf8282c6c97cbe043deaa6963533c94d8b

Compatibility test results for aptos-node-v1.9.5 ==> b8900ecf8282c6c97cbe043deaa6963533c94d8b (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6741 txn/s, latency: 4900 ms, (p50: 4800 ms, p90: 8100 ms, p99: 9300 ms), latency samples: 235940
2. Upgrading first Validator to new version: b8900ecf8282c6c97cbe043deaa6963533c94d8b
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 688 txn/s, latency: 35594 ms, (p50: 39300 ms, p90: 54200 ms, p99: 55700 ms), latency samples: 57120
3. Upgrading rest of first batch to new version: b8900ecf8282c6c97cbe043deaa6963533c94d8b
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 336 txn/s, submitted: 548 txn/s, expired: 212 txn/s, latency: 35511 ms, (p50: 34200 ms, p90: 58000 ms, p99: 61000 ms), latency samples: 29265
4. upgrading second batch to new version: b8900ecf8282c6c97cbe043deaa6963533c94d8b
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2050 txn/s, latency: 14439 ms, (p50: 14800 ms, p90: 19900 ms, p99: 20200 ms), latency samples: 100480
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> b8900ecf8282c6c97cbe043deaa6963533c94d8b passed
Test Ok

@sionescu sionescu disabled auto-merge March 27, 2024 19:33
@sionescu sionescu merged commit 91a603c into main Mar 27, 2024
45 checks passed
@sionescu sionescu deleted the stelian/disable-old-repo branch March 27, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants