Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make install dir if not present in aptos update revela #12401

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

banool
Copy link
Contributor

@banool banool commented Mar 6, 2024

Description

If the user doesn't already have the default install directory, it would previously fail. Now we make the directory. This is how the Python install script does it.

Test Plan

First delete the default install dir, e.g. for linux ~/.local/bin.

Before:

$ cargo run -p aptos -- update revela
{
  "Error": "Unexpected error: Failed to build self-update configuration: ConfigError: `bin_install_dir` must be a directory"
}

After:

Checking target-arch... aarch64-apple-darwin
Checking current version... v0.0.0
Looking for tag: v1.0.0

revela release status:
  * New exe release: "revela-aarch64-apple-darwin"
  * New exe download url: "https://api.github.com/repos/verichains/revela/releases/assets/155171154"
  * Installing to: /Users/dport/.local/bin

The new release will be downloaded/extracted and the existing binary will be replaced.
Do you want to continue? [Y/n] y
Downloading...
Extracting archive... Moving binary file to /Users/dport/.local/bin... Done
{
  "Result": "Successfully installed Revela v1.0.0"
}

@banool banool requested a review from gregnazario as a code owner March 6, 2024 16:09
Copy link

trunk-io bot commented Mar 6, 2024

⏱️ 2h 7m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 52m 🟩🟩
rust-unit-tests 36m 🟩
rust-lints 11m 🟩
run-tests-main-branch 9m 🟩🟩
check 7m 🟩
general-lints 5m 🟩
check-dynamic-deps 5m 🟩🟩
semgrep/ci 55s 🟩🟩
file_change_determinator 23s 🟩🟩
file_change_determinator 21s 🟩🟩
permission-check 15s 🟩🟩
permission-check 6s 🟩🟩
permission-check 6s 🟩🟩
permission-check 5s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
windows-build 29m 20m +47%

settingsfeedbackdocs ⋅ learn more about trunk.io

@banool banool force-pushed the banool/aptos-update-make-dir branch from b95e186 to 996bf86 Compare March 6, 2024 16:12
@banool banool merged commit bb60b3a into main Mar 6, 2024
42 checks passed
@banool banool deleted the banool/aptos-update-make-dir branch March 6, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant