Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Upgrade actions/checkout to v4 #12025

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

sionescu
Copy link
Contributor

@sionescu sionescu commented Feb 15, 2024

Description

actions/checkout@v3 relies on Nodejs 16 which has been deprecated by Github.

@sionescu sionescu requested a review from geekflyer February 15, 2024 00:33
@sionescu sionescu requested review from a team as code owners February 15, 2024 00:33
Copy link

trunk-io bot commented Feb 15, 2024

⏱️ 68h 6m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 12h 38m 🟩🟥🟥
test-replay / replay-verify (16) 4h 🟥🟥
test-replay / replay-verify (9) 4h 🟥🟥
test-replay / replay-verify (10) 4h 🟥🟥
test-replay / replay-verify (8) 3h 51m 🟩🟥
test-replay / replay-verify (15) 3h 17m 🟩🟩
test-replay / replay-verify (11) 3h 13m 🟩🟩
test-replay / replay-verify (0) 2h 43m 🟩🟩
test-replay / replay-verify (6) 2h 33m 🟩🟩
test-replay / replay-verify (12) 2h 25m 🟩🟩
test-replay / replay-verify (2) 2h 13m 🟩🟩
test-replay / replay-verify (13) 2h 10m 🟩🟩
test-replay / replay-verify (1) 2h 6m 🟩🟩
test-replay / replay-verify (4) 2h 2m 🟩🟩
test-replay / replay-verify (14) 1h 53m 🟩🟩
test-replay / replay-verify (5) 1h 48m 🟩🟩
test-replay / replay-verify (7) 1h 38m 🟩🟩
test-replay / replay-verify (3) 1h 37m 🟩🟩
rust-move-unit-coverage 1h 8m 🟥🟩
rust-smoke-tests 1h 3m 🟩🟩
forge-framework-upgrade-test / forge 58m 🟥
windows-build 50m 🟩🟩🟩
prover-inconsistency-test 41m 🟥🟥🟥🟥
execution-performance / single-node-performance 38m 🟩🟩
rust-images / rust-all 35m 🟩🟩
rust-move-tests 35m 🟩🟩
rust-lints 29m 🟩🟩🟩
forge-e2e-test / forge 28m 🟩🟩
forge-compat-test / forge 26m 🟩🟩
rust-images-performance / rust-all 25m 🟩
cli-e2e-tests / run-cli-tests 17m 🟥🟥
run-tests-main-branch 15m 🟥🟥🟥🟥
check 13m 🟥🟩🟩
rust-images-failpoints / rust-all 12m 🟩
general-lints 11m 🟩🟩🟩🟩
build 10m 🟥🟥🟥🟥
check-dynamic-deps 6m 🟩🟩🟩
determine-test-metadata 3m 🟩🟩
determine-test-metadata 3m 🟩🟩
determine-test-metadata 3m 🟩🟩
cargo-metadata 2m 🟩🟩
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 2m 🟩
node-api-compatibility-tests / node-api-compatibility-tests 2m 🟩🟩
update 1m 🟩🟩🟩
semgrep/ci 58s 🟩🟩🟩
file_change_determinator 42s 🟩🟩🟩🟩
file_change_determinator 33s 🟩🟩🟩
file_change_determinator 29s 🟩🟩🟩
execution-performance / file_change_determinator 23s 🟩🟩
determine-test-metadata 19s 🟩🟩
permission-check 11s 🟩🟩🟩
permission-check 9s 🟩🟩🟩
determine-docker-build-metadata 9s 🟩🟩🟩
permission-check 9s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 7s 🟩🟩🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-unit-tests 6h 31m +1077%
cli-e2e-tests / run-cli-tests 9m 7m +32%
rust-images / rust-all 16m 12m +27%

settingsfeedbackdocs ⋅ learn more about trunk.io

@sionescu sionescu enabled auto-merge (rebase) February 15, 2024 18:30
@sionescu sionescu force-pushed the stelian/update-gh-actions branch from c2ea492 to 7333d99 Compare February 15, 2024 18:38

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.8.3 ==> 7333d99c9f8b1d3ccfa4deca742c1cf323eafe91

Compatibility test results for aptos-node-v1.8.3 ==> 7333d99c9f8b1d3ccfa4deca742c1cf323eafe91 (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4746 txn/s, latency: 6737 ms, (p50: 6600 ms, p90: 10500 ms, p99: 13000 ms), latency samples: 180380
2. Upgrading first Validator to new version: 7333d99c9f8b1d3ccfa4deca742c1cf323eafe91
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1775 txn/s, latency: 15973 ms, (p50: 18900 ms, p90: 22000 ms, p99: 22600 ms), latency samples: 92340
3. Upgrading rest of first batch to new version: 7333d99c9f8b1d3ccfa4deca742c1cf323eafe91
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1778 txn/s, latency: 15828 ms, (p50: 19200 ms, p90: 21900 ms, p99: 22800 ms), latency samples: 92480
4. upgrading second batch to new version: 7333d99c9f8b1d3ccfa4deca742c1cf323eafe91
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2991 txn/s, latency: 9997 ms, (p50: 9900 ms, p90: 18000 ms, p99: 20200 ms), latency samples: 125660
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> 7333d99c9f8b1d3ccfa4deca742c1cf323eafe91 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 7333d99c9f8b1d3ccfa4deca742c1cf323eafe91

two traffics test: inner traffic : committed: 7856 txn/s, latency: 4875 ms, (p50: 4500 ms, p90: 6000 ms, p99: 11100 ms), latency samples: 3386100
two traffics test : committed: 100 txn/s, latency: 2105 ms, (p50: 2100 ms, p90: 2300 ms, p99: 3000 ms), latency samples: 1700
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.234, avg: 0.204", "QsPosToProposal: max: 0.151, avg: 0.139", "ConsensusProposalToOrdered: max: 0.593, avg: 0.535", "ConsensusOrderedToCommit: max: 0.482, avg: 0.453", "ConsensusProposalToCommit: max: 1.006, avg: 0.988"]
Max round gap was 1 [limit 4] at version 1389739. Max no progress secs was 4.6753073 [limit 15] at version 1389739.
Test Ok

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b16e80) 71.5% compared to head (7333d99) 71.5%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12025   +/-   ##
=======================================
  Coverage    71.5%    71.5%           
=======================================
  Files         802      802           
  Lines      184339   184339           
=======================================
+ Hits       131816   131821    +5     
+ Misses      52523    52518    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sionescu sionescu disabled auto-merge February 15, 2024 19:22
@sionescu sionescu merged commit 04d078f into main Feb 15, 2024
105 of 117 checks passed
@sionescu sionescu deleted the stelian/update-gh-actions branch February 15, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants