Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jwk #9: smoke tests #11862

Merged
merged 23 commits into from
Feb 6, 2024
Merged

jwk #9: smoke tests #11862

merged 23 commits into from
Feb 6, 2024

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Feb 1, 2024

Description

Test Plan

Copy link

trunk-io bot commented Feb 1, 2024

⏱️ 23h total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-coverage 9h 10m 🟩🟩
rust-smoke-coverage 7h 4m 🟩🟩
rust-unit-tests 1h 32m 🟥🟩
windows-build 1h 29m 🟩🟩🟩🟩🟩
execution-performance / single-node-performance 36m 🟩🟩
rust-lints 36m 🟩🟩🟩🟩
rust-smoke-tests 34m 🟩
check 20m 🟩🟩🟩🟩
run-tests-main-branch 20m 🟩🟩🟩🟩
rust-images / rust-all 16m 🟩
forge-e2e-test / forge 14m 🟩
general-lints 13m 🟩🟩🟩🟩🟩
forge-compat-test / forge 12m 🟩
check-dynamic-deps 10m 🟩🟩🟩🟩🟩
cli-e2e-tests / run-cli-tests 7m 🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 2m 🟩
file_change_determinator 54s 🟩🟩🟩🟩🟩
file_change_determinator 52s 🟩🟩🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 51s 🟩
upload-to-codecov 28s 🟩🟩
file_change_determinator 19s 🟩🟩
execution-performance / file_change_determinator 19s 🟩🟩
permission-check 16s 🟩🟩🟩🟩🟩
permission-check 13s 🟩🟩🟩🟩🟩
permission-check 12s 🟩🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩🟩
permission-check 4s 🟩🟩
determine-docker-build-metadata 4s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-unit-tests 38m 31m +22%

settingsfeedbackdocs ⋅ learn more about trunk.io

@zjma zjma changed the title wk consensus smoke tests jwk #9: smoke tests Feb 1, 2024
@zjma zjma added the JWK label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 738 lines in your changes are missing coverage. Please review.

Comparison is base (793563f) 70.1% compared to head (3df6061) 69.9%.
Report is 10 commits behind head on main.

❗ Current head 3df6061 differs from pull request most recent head c24fd72. Consider uploading reports for the commit c24fd72 to get more accurate results

Files Patch % Lines
crates/aptos-jwk-consensus/src/epoch_manager.rs 0.0% 138 Missing ⚠️
crates/aptos-jwk-consensus/src/jwk_observer.rs 0.0% 95 Missing ⚠️
aptos-move/aptos-vm/src/validator_txns/jwk.rs 0.0% 93 Missing ⚠️
crates/aptos-jwk-consensus/src/jwk_manager/mod.rs 66.9% 82 Missing ⚠️
crates/aptos-jwk-consensus/src/network.rs 9.3% 78 Missing ⚠️
types/src/jwks/mod.rs 19.6% 41 Missing ⚠️
aptos-node/src/lib.rs 0.0% 32 Missing ⚠️
...tos-jwk-consensus/src/certified_update_producer.rs 0.0% 27 Missing ⚠️
crates/aptos-jwk-consensus/src/lib.rs 0.0% 21 Missing ⚠️
types/src/jwks/jwk/mod.rs 28.5% 20 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff            @@
##             main   #11862     +/-   ##
=========================================
- Coverage    70.1%    69.9%   -0.3%     
=========================================
  Files        2182     2192     +10     
  Lines      414855   414837     -18     
=========================================
- Hits       291207   290321    -886     
- Misses     123648   124516    +868     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from zjma/jwk_consensus_wired_into_node to main February 5, 2024 22:12
@zjma zjma marked this pull request as ready for review February 5, 2024 23:17
@zjma zjma added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Feb 5, 2024
@zjma zjma enabled auto-merge (squash) February 5, 2024 23:21

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Feb 5, 2024

✅ Forge suite compat success on aptos-node-v1.8.3 ==> c24fd72d3360056b598209dedf53169618ff276b

Compatibility test results for aptos-node-v1.8.3 ==> c24fd72d3360056b598209dedf53169618ff276b (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4886 txn/s, latency: 6383 ms, (p50: 6300 ms, p90: 9500 ms, p99: 11700 ms), latency samples: 190580
2. Upgrading first Validator to new version: c24fd72d3360056b598209dedf53169618ff276b
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1795 txn/s, latency: 16286 ms, (p50: 18900 ms, p90: 22200 ms, p99: 22500 ms), latency samples: 93380
3. Upgrading rest of first batch to new version: c24fd72d3360056b598209dedf53169618ff276b
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1395 txn/s, latency: 20340 ms, (p50: 20400 ms, p90: 31000 ms, p99: 33000 ms), latency samples: 66960
4. upgrading second batch to new version: c24fd72d3360056b598209dedf53169618ff276b
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3082 txn/s, latency: 10368 ms, (p50: 9900 ms, p90: 12900 ms, p99: 15500 ms), latency samples: 129480
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> c24fd72d3360056b598209dedf53169618ff276b passed
Test Ok

Copy link
Contributor

github-actions bot commented Feb 5, 2024

✅ Forge suite realistic_env_max_load success on c24fd72d3360056b598209dedf53169618ff276b

two traffics test: inner traffic : committed: 6964 txn/s, latency: 5503 ms, (p50: 5100 ms, p90: 7300 ms, p99: 10800 ms), latency samples: 3008720
two traffics test : committed: 100 txn/s, latency: 2166 ms, (p50: 2100 ms, p90: 2600 ms, p99: 5100 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.244, avg: 0.200", "QsPosToProposal: max: 0.150, avg: 0.145", "ConsensusProposalToOrdered: max: 0.600, avg: 0.551", "ConsensusOrderedToCommit: max: 0.476, avg: 0.450", "ConsensusProposalToCommit: max: 1.030, avg: 1.001"]
Max round gap was 1 [limit 4] at version 1382018. Max no progress secs was 4.6804333 [limit 15] at version 1382018.
Test Ok

@zjma zjma merged commit 8b514bb into main Feb 6, 2024
107 of 121 checks passed
@zjma zjma deleted the zjma/jwk_consensus_smoke_tests branch February 6, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR JWK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants