Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AdminService] Implement a naive passcode authentication. #11028

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[AdminService] Implement a naive passcode authentication. #11028

merged 1 commit into from
Nov 21, 2023

Conversation

grao1991
Copy link
Contributor

@grao1991 grao1991 commented Nov 21, 2023 •
edited
Loading

Description

Allow authentication through query parameter passcode.

Test Plan

Manually tested on local net.

@grao1991 grao1991 force-pushed the grao_admin branch 2 times, most recently from 98557c8 to 682d6ee Compare November 21, 2023 20:46
@grao1991 grao1991 marked this pull request as ready for review November 21, 2023 20:59
@grao1991 grao1991 enabled auto-merge (squash) November 21, 2023 21:32
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 02572f0b16edf7c54f1b103ab012f122dfb0dd3c

two traffics test: inner traffic : committed: 7328 txn/s, latency: 5337 ms, (p50: 5100 ms, p90: 6600 ms, p99: 12000 ms), latency samples: 3173380
two traffics test : committed: 100 txn/s, latency: 2436 ms, (p50: 2400 ms, p90: 2900 ms, p99: 4300 ms), latency samples: 1840
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.206, avg: 0.196", "QsPosToProposal: max: 0.212, avg: 0.182", "ConsensusProposalToOrdered: max: 0.704, avg: 0.663", "ConsensusOrderedToCommit: max: 0.551, avg: 0.520", "ConsensusProposalToCommit: max: 1.243, avg: 1.184"]
Max round gap was 1 [limit 4] at version 1514047. Max no progress secs was 4.13814 [limit 10] at version 1514047.
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.7.3 ==> 02572f0b16edf7c54f1b103ab012f122dfb0dd3c

Compatibility test results for aptos-node-v1.7.3 ==> 02572f0b16edf7c54f1b103ab012f122dfb0dd3c (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 3942 txn/s, latency: 6959 ms, (p50: 5400 ms, p90: 11400 ms, p99: 20200 ms), latency samples: 177420
2. Upgrading first Validator to new version: 02572f0b16edf7c54f1b103ab012f122dfb0dd3c
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1820 txn/s, latency: 15867 ms, (p50: 18600 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92840
3. Upgrading rest of first batch to new version: 02572f0b16edf7c54f1b103ab012f122dfb0dd3c
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1855 txn/s, latency: 15810 ms, (p50: 18500 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92760
4. upgrading second batch to new version: 02572f0b16edf7c54f1b103ab012f122dfb0dd3c
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3196 txn/s, latency: 9723 ms, (p50: 9900 ms, p90: 12700 ms, p99: 15400 ms), latency samples: 127840
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 02572f0b16edf7c54f1b103ab012f122dfb0dd3c passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.7.3 ==> 02572f0b16edf7c54f1b103ab012f122dfb0dd3c

Compatibility test results for aptos-node-v1.7.3 ==> 02572f0b16edf7c54f1b103ab012f122dfb0dd3c (PR)
Upgrade the nodes to version: 02572f0b16edf7c54f1b103ab012f122dfb0dd3c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 6993 txn/s, latency: 4821 ms, (p50: 4800 ms, p90: 7700 ms, p99: 8200 ms), latency samples: 244780
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 02572f0b16edf7c54f1b103ab012f122dfb0dd3c passed
Test Ok

@grao1991 grao1991 merged commit f55b235 into main Nov 21, 2023
86 of 87 checks passed
@grao1991 grao1991 deleted the grao_admin branch November 21, 2023 22:40
gedigi pushed a commit that referenced this pull request Nov 21, 2023
@grao1991 @gedigi
[AdminService] Implement a naive passcode authentication. (#11028)
aa2b15c
bowenyang007 pushed a commit that referenced this pull request Dec 7, 2023
@grao1991 @bowenyang007
[AdminService] Implement a naive passcode authentication. (#11028)
d708e53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-aptos igor-aptos igor-aptos approved these changes

@sitalkedia sitalkedia sitalkedia approved these changes

@msmouse msmouse Awaiting requested review from msmouse

@zekun000 zekun000 Awaiting requested review from zekun000

@JoshLind JoshLind Awaiting requested review from JoshLind JoshLind is a code owner

@gregnazario gregnazario Awaiting requested review from gregnazario gregnazario is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grao1991 @sitalkedia @igor-aptos