Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forge] update node version to v1.7.3 #10734

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[forge] update node version to v1.7.3 #10734

merged 1 commit into from
Oct 30, 2023

Conversation

sausagee
Copy link
Contributor

Description

Update the base version used in Forge test to the one in mainnet.

Test Plan

Forge test in CI uses the specified version and passes.

@sausagee sausagee requested review from a team as code owners October 30, 2023 19:29
Copy link
Contributor

@rustielin rustielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Also re test plan, the jobs that run on your PR will not have these changes, due to the pull_request_target trigger. I've started a canary for you here: https://github.com/aptos-labs/aptos-core/actions/runs/6697816076, which triggers the workflow using your PR branch

Copy link
Contributor

@perryjrandall perryjrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank u ser

@sausagee sausagee enabled auto-merge (squash) October 30, 2023 19:34
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.7.2 ==> d7372b1142eaa0742e9ba6f3a57b5e422100893e

Compatibility test results for aptos-node-v1.7.2 ==> d7372b1142eaa0742e9ba6f3a57b5e422100893e (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.2
compatibility::simple-validator-upgrade::liveness-check : committed: 4880 txn/s, latency: 6613 ms, (p50: 7200 ms, p90: 8900 ms, p99: 10100 ms), latency samples: 180560
2. Upgrading first Validator to new version: d7372b1142eaa0742e9ba6f3a57b5e422100893e
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1775 txn/s, latency: 16133 ms, (p50: 19300 ms, p90: 22000 ms, p99: 22500 ms), latency samples: 92320
3. Upgrading rest of first batch to new version: d7372b1142eaa0742e9ba6f3a57b5e422100893e
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1774 txn/s, latency: 15833 ms, (p50: 19300 ms, p90: 21800 ms, p99: 22500 ms), latency samples: 92280
4. upgrading second batch to new version: d7372b1142eaa0742e9ba6f3a57b5e422100893e
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3602 txn/s, latency: 8745 ms, (p50: 9800 ms, p90: 12300 ms, p99: 12600 ms), latency samples: 144080
5. check swarm health
Compatibility test for aptos-node-v1.7.2 ==> d7372b1142eaa0742e9ba6f3a57b5e422100893e passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on d7372b1142eaa0742e9ba6f3a57b5e422100893e

two traffics test: inner traffic : committed: 7967 txn/s, latency: 4921 ms, (p50: 4800 ms, p90: 6000 ms, p99: 10600 ms), latency samples: 3442140
two traffics test : committed: 100 txn/s, latency: 2258 ms, (p50: 2200 ms, p90: 2700 ms, p99: 3300 ms), latency samples: 1860
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.223, avg: 0.198", "QsPosToProposal: max: 0.178, avg: 0.161", "ConsensusProposalToOrdered: max: 0.609, avg: 0.592", "ConsensusOrderedToCommit: max: 0.578, avg: 0.537", "ConsensusProposalToCommit: max: 1.173, avg: 1.129"]
Max round gap was 1 [limit 4] at version 1584763. Max no progress secs was 4.477021 [limit 10] at version 1584763.
Test Ok

@sausagee sausagee merged commit 9de82b7 into main Oct 30, 2023
88 of 103 checks passed
@sausagee sausagee deleted the update_node_ver branch October 30, 2023 20:02
@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.7.2 ==> d7372b1142eaa0742e9ba6f3a57b5e422100893e

Compatibility test results for aptos-node-v1.7.2 ==> d7372b1142eaa0742e9ba6f3a57b5e422100893e (PR)
Upgrade the nodes to version: d7372b1142eaa0742e9ba6f3a57b5e422100893e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4119 txn/s, latency: 4839 ms, (p50: 4800 ms, p90: 7800 ms, p99: 8400 ms), latency samples: 247160
5. check swarm health
Compatibility test for aptos-node-v1.7.2 ==> d7372b1142eaa0742e9ba6f3a57b5e422100893e passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants