Limit the maximum identifier length

[junkil-park]

Description

cherry pick the PR [VM] Limit the maximum identifier length

Test Plan

cargo test

[github-actions]

✅ Forge suite compat success on aptos-node-v1.6.2 ==> 7cc4afe50f2b50b0aece765018f26f622f05f39c

Compatibility test results for aptos-node-v1.6.2 ==> 7cc4afe50f2b50b0aece765018f26f622f05f39c (PR)
1. Check liveness of validators at old version: aptos-node-v1.6.2
compatibility::simple-validator-upgrade::liveness-check : committed: 2926 txn/s, latency: 7785 ms, (p50: 6900 ms, p90: 12100 ms, p99: 21000 ms), latency samples: 160980
2. Upgrading first Validator to new version: 7cc4afe50f2b50b0aece765018f26f622f05f39c
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1776 txn/s, latency: 16108 ms, (p50: 19200 ms, p90: 22200 ms, p99: 22500 ms), latency samples: 92360
3. Upgrading rest of first batch to new version: 7cc4afe50f2b50b0aece765018f26f622f05f39c
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1259 txn/s, submitted: 1310 txn/s, expired: 51 txn/s, latency: 15159 ms, (p50: 17300 ms, p90: 21900 ms, p99: 22600 ms), latency samples: 83108
4. upgrading second batch to new version: 7cc4afe50f2b50b0aece765018f26f622f05f39c
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3249 txn/s, latency: 9470 ms, (p50: 10100 ms, p90: 12800 ms, p99: 14000 ms), latency samples: 133220
5. check swarm health
Compatibility test for aptos-node-v1.6.2 ==> 7cc4afe50f2b50b0aece765018f26f622f05f39c passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 7cc4afe50f2b50b0aece765018f26f622f05f39c

two traffics test: inner traffic : committed: 6396 txn/s, latency: 6129 ms, (p50: 5700 ms, p90: 7600 ms, p99: 14700 ms), latency samples: 2769700
two traffics test : committed: 100 txn/s, latency: 3120 ms, (p50: 3000 ms, p90: 3700 ms, p99: 10400 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.254, avg: 0.215", "QsPosToProposal: max: 0.422, avg: 0.180", "ConsensusProposalToOrdered: max: 0.637, avg: 0.588", "ConsensusOrderedToCommit: max: 0.509, avg: 0.484", "ConsensusProposalToCommit: max: 1.138, avg: 1.072"]
Max round gap was 1 [limit 4] at version 1251332. Max no progress secs was 3.56163 [limit 10] at version 1251332.
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[davidiw]

Folks, let's not break compatibility with main. I'm reverting this PR.

This need to take a flag that has not yet been allocated. So maybe we get this landed on main first?

[github-actions]

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 7cc4afe50f2b50b0aece765018f26f622f05f39c

Compatibility test results for aptos-node-v1.5.1 ==> 7cc4afe50f2b50b0aece765018f26f622f05f39c (PR)
Upgrade the nodes to version: 7cc4afe50f2b50b0aece765018f26f622f05f39c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 3506 txn/s, latency: 6452 ms, (p50: 6300 ms, p90: 9500 ms, p99: 15000 ms), latency samples: 185860
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 7cc4afe50f2b50b0aece765018f26f622f05f39c passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking