-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Support Docker socket in home directory for local testnet #10654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banool
force-pushed
the
banool/local-testnet-docker-home
branch
2 times, most recently
from
October 24, 2023 20:49
da84a10
to
3b1344d
Compare
banool
changed the title
Support Docker socket in home directory
[CLI] Support Docker socket in home directory for local testnet
Oct 24, 2023
banool
force-pushed
the
banool/local-testnet-docker-home
branch
from
October 24, 2023 20:51
3b1344d
to
f4887f2
Compare
gregnazario
approved these changes
Oct 24, 2023
Ok(version) => Ok((docker, version)), | ||
Err(err) => { | ||
warn!( | ||
"Got this error trying to use default Docker socket location: {:#}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Received
0xmaayan
approved these changes
Oct 24, 2023
banool
force-pushed
the
banool/local-testnet-docker-home
branch
from
October 25, 2023 10:30
f4887f2
to
fbe7ff8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
banool
force-pushed
the
banool/local-testnet-docker-home
branch
from
October 25, 2023 11:26
e93e11b
to
34fe33c
Compare
banool
force-pushed
the
banool/local-testnet-docker-home
branch
from
October 25, 2023 11:59
34fe33c
to
00b2d77
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This won't be necessary if fussybeaver/bollard#345 gets resolved.
Test Plan
I switched my Docker Desktop into the mode where all the binaries are stored in my user directory and disabled the "allow default docker socket" to be used feature:
I then ran the local testnet successfully.
I tested that this works fine on Windows (NT) too.