Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Support Docker socket in home directory for local testnet #10654

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

banool
Copy link
Contributor

@banool banool commented Oct 24, 2023

Description

Note: This won't be necessary if fussybeaver/bollard#345 gets resolved.

Test Plan

I switched my Docker Desktop into the mode where all the binaries are stored in my user directory and disabled the "allow default docker socket" to be used feature:
image

I then ran the local testnet successfully.

I tested that this works fine on Windows (NT) too.

@banool banool force-pushed the banool/local-testnet-docker-home branch 2 times, most recently from da84a10 to 3b1344d Compare October 24, 2023 20:49
@banool banool marked this pull request as ready for review October 24, 2023 20:49
@banool banool changed the title Support Docker socket in home directory [CLI] Support Docker socket in home directory for local testnet Oct 24, 2023
@banool banool force-pushed the banool/local-testnet-docker-home branch from 3b1344d to f4887f2 Compare October 24, 2023 20:51
Ok(version) => Ok((docker, version)),
Err(err) => {
warn!(
"Got this error trying to use default Docker socket location: {:#}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Received

@banool banool force-pushed the banool/local-testnet-docker-home branch from f4887f2 to fbe7ff8 Compare October 25, 2023 10:30
@banool banool requested a review from davidiw as a code owner October 25, 2023 10:30
@banool banool enabled auto-merge (squash) October 25, 2023 10:30
@banool banool disabled auto-merge October 25, 2023 10:31
@banool banool enabled auto-merge (rebase) October 25, 2023 10:32
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@banool banool disabled auto-merge October 25, 2023 11:25
@banool banool force-pushed the banool/local-testnet-docker-home branch from e93e11b to 34fe33c Compare October 25, 2023 11:26
@banool banool force-pushed the banool/local-testnet-docker-home branch from 34fe33c to 00b2d77 Compare October 25, 2023 11:59
@banool banool enabled auto-merge (squash) October 25, 2023 12:30
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.7.2 ==> 00b2d7795fc93e7be55f734eb2ac43b11e3e1178

Compatibility test results for aptos-node-v1.7.2 ==> 00b2d7795fc93e7be55f734eb2ac43b11e3e1178 (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.2
compatibility::simple-validator-upgrade::liveness-check : committed: 4678 txn/s, latency: 6543 ms, (p50: 6700 ms, p90: 8000 ms, p99: 10800 ms), latency samples: 191820
2. Upgrading first Validator to new version: 00b2d7795fc93e7be55f734eb2ac43b11e3e1178
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1838 txn/s, latency: 15692 ms, (p50: 18400 ms, p90: 22200 ms, p99: 22500 ms), latency samples: 91940
3. Upgrading rest of first batch to new version: 00b2d7795fc93e7be55f734eb2ac43b11e3e1178
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1854 txn/s, latency: 15775 ms, (p50: 18600 ms, p90: 22200 ms, p99: 22500 ms), latency samples: 92720
4. upgrading second batch to new version: 00b2d7795fc93e7be55f734eb2ac43b11e3e1178
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3476 txn/s, latency: 9142 ms, (p50: 9700 ms, p90: 12600 ms, p99: 12700 ms), latency samples: 146000
5. check swarm health
Compatibility test for aptos-node-v1.7.2 ==> 00b2d7795fc93e7be55f734eb2ac43b11e3e1178 passed
Test Ok

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 00b2d7795fc93e7be55f734eb2ac43b11e3e1178

two traffics test: inner traffic : committed: 7192 txn/s, latency: 5443 ms, (p50: 5000 ms, p90: 6600 ms, p99: 22900 ms), latency samples: 3107180
two traffics test : committed: 100 txn/s, latency: 2646 ms, (p50: 2200 ms, p90: 3000 ms, p99: 22400 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.204, avg: 0.196", "QsPosToProposal: max: 0.521, avg: 0.216", "ConsensusProposalToOrdered: max: 0.697, avg: 0.627", "ConsensusOrderedToCommit: max: 0.555, avg: 0.508", "ConsensusProposalToCommit: max: 1.201, avg: 1.135"]
Max round gap was 1 [limit 4] at version 1667108. Max no progress secs was 4.339048 [limit 10] at version 1667108.
Test Ok

@banool banool merged commit b5cdf0f into main Oct 25, 2023
81 of 84 checks passed
@banool banool deleted the banool/local-testnet-docker-home branch October 25, 2023 14:07
@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.7.2 ==> 00b2d7795fc93e7be55f734eb2ac43b11e3e1178

Compatibility test results for aptos-node-v1.7.2 ==> 00b2d7795fc93e7be55f734eb2ac43b11e3e1178 (PR)
Upgrade the nodes to version: 00b2d7795fc93e7be55f734eb2ac43b11e3e1178
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4253 txn/s, latency: 4836 ms, (p50: 4800 ms, p90: 7800 ms, p99: 8400 ms), latency samples: 242440
5. check swarm health
Compatibility test for aptos-node-v1.7.2 ==> 00b2d7795fc93e7be55f734eb2ac43b11e3e1178 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants