Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Increase the threshold of versions between two JMT snapshots. #10437

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

grao1991
Copy link
Contributor

@grao1991 grao1991 commented Oct 7, 2023

Description

JMT computation and commit are parallelizable now. It's time to increase the threshold.

Test Plan

@grao1991 grao1991 requested review from areshand and zekun000 October 7, 2023 07:25
@grao1991 grao1991 enabled auto-merge (squash) October 7, 2023 07:28
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on a0a367bea7466b6babc73289ba529a9a4a3c1b7f

two traffics test: inner traffic : committed: 7410 txn/s, latency: 5285 ms, (p50: 5000 ms, p90: 6000 ms, p99: 23400 ms), latency samples: 3208920
two traffics test : committed: 100 txn/s, latency: 2270 ms, (p50: 2200 ms, p90: 2800 ms, p99: 4100 ms), latency samples: 1840
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.207, avg: 0.199", "QsPosToProposal: max: 0.474, avg: 0.217", "ConsensusProposalToOrdered: max: 0.701, avg: 0.640", "ConsensusOrderedToCommit: max: 0.549, avg: 0.513", "ConsensusProposalToCommit: max: 1.225, avg: 1.153"]
Max round gap was 1 [limit 4] at version 1616592. Max no progress secs was 4.435105 [limit 10] at version 1616592.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.6.2 ==> a0a367bea7466b6babc73289ba529a9a4a3c1b7f

Compatibility test results for aptos-node-v1.6.2 ==> a0a367bea7466b6babc73289ba529a9a4a3c1b7f (PR)
1. Check liveness of validators at old version: aptos-node-v1.6.2
compatibility::simple-validator-upgrade::liveness-check : committed: 3971 txn/s, latency: 8148 ms, (p50: 9000 ms, p90: 10800 ms, p99: 12100 ms), latency samples: 150900
2. Upgrading first Validator to new version: a0a367bea7466b6babc73289ba529a9a4a3c1b7f
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1775 txn/s, latency: 15761 ms, (p50: 18700 ms, p90: 21800 ms, p99: 22600 ms), latency samples: 92300
3. Upgrading rest of first batch to new version: a0a367bea7466b6babc73289ba529a9a4a3c1b7f
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 94 txn/s, submitted: 308 txn/s, expired: 214 txn/s, latency: 10494 ms, (p50: 4800 ms, p90: 41300 ms, p99: 64100 ms), latency samples: 16638
4. upgrading second batch to new version: a0a367bea7466b6babc73289ba529a9a4a3c1b7f
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3584 txn/s, latency: 8725 ms, (p50: 9900 ms, p90: 12400 ms, p99: 12700 ms), latency samples: 143380
5. check swarm health
Compatibility test for aptos-node-v1.6.2 ==> a0a367bea7466b6babc73289ba529a9a4a3c1b7f passed
Test Ok

@grao1991 grao1991 merged commit 9594866 into main Oct 10, 2023
42 of 45 checks passed
@grao1991 grao1991 deleted the grao_batch_size branch October 10, 2023 05:07
@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> a0a367bea7466b6babc73289ba529a9a4a3c1b7f

Compatibility test results for aptos-node-v1.5.1 ==> a0a367bea7466b6babc73289ba529a9a4a3c1b7f (PR)
Upgrade the nodes to version: a0a367bea7466b6babc73289ba529a9a4a3c1b7f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4302 txn/s, latency: 4962 ms, (p50: 5100 ms, p90: 7800 ms, p99: 8700 ms), latency samples: 236640
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> a0a367bea7466b6babc73289ba529a9a4a3c1b7f passed
Test Ok

fEst1ck pushed a commit to fEst1ck/aptos-core that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants