Skip to content

Commit

Permalink
Address reviewer feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Clay Murphy authored and Clay Murphy committed Mar 6, 2023
1 parent 7cadb0e commit 9d4dc0e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
9 changes: 1 addition & 8 deletions developer-docs-site/docs/community/contributions/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,4 @@ The source materials for both code and docs live in GitHub. See [Contribute](../

| Contribution | Description | Author | Date added/updated |
| --- | --- | --- | --- |
| [Multisig Python SDK tooling and tutorial](https://github.com/aptos-labs/aptos-core/pull/6788) | This tutorial introduces assorted [K-of-N multi-signer authentication](../../concepts/accounts.md#multi-signer-authentication) operations | [alnoki](https://github.com/alnoki) | 2023-03-06 |
| [Remix IDE plugin for Move](https://github.com/aptos-labs/aptos-core/pull/6458) | This tutorial describes a plugin that can develop you develop Aptos Move modules with the Remix IDE. | [0xhsy](https://github.com/0xhsy) | 2023-03-02 |
| [How Base Gas Works](../../concepts/base-gas.md) | Aptos transactions by default charge a base gas fee, regardless of market conditions. This document explains that process. | [alnoki](https://github.com/alnoki) | 2022-10-06 |

TODO: Update Multisig and Remix IDE with live documents once in place. Not Multisig is landing in two parts:
https://github.com/aptos-labs/aptos-core/pull/6788/
https://github.com/aptos-labs/aptos-core/pull/6356
Also announce in See what's new as sub-bullets of each page announcement.
| [How Base Gas Works](../../concepts/base-gas.md) | Aptos transactions by default charge a base gas fee, regardless of market conditions. This document explains that process. | [alnoki](https://github.com/alnoki) | 2022-10-06 |
4 changes: 2 additions & 2 deletions developer-docs-site/docs/community/site-updates.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,12 @@ To update [Aptos.dev](http://Aptos.dev) directly:
3. For local edits, use the [local doc build instructions](https://github.com/aptos-labs/aptos-core/blob/main/developer-docs-site/README.md) to see your updates at: [http://localhost:3000](http://localhost:3000)
4. After creating the pull request, use the *Deploy Preview* in Netlify to see your updates made in web browser or via local editor by replacing the *prnumber* with your own in:
[https://deploy-preview-prnumber--aptos-developer-docs.netlify.app/](https://deploy-preview-prnumber--aptos-developer-docs.netlify.app/)
5. Have at least two members of Aptos Labs review and test your changes.
5. Have at least two verified reviewers from Aptos Labs review and test your changes.
6. Make direct commits during review.
7. Request review from the Docs team (currently, clay-aptos in GitHub).
8. Use the *Assignee* field in the PR to identify the review the change is blocking upon.
9. Receive and address *all feedback*.
10. Get approval from at least one peer in Eng and the Docs team.
10. Get approval from at least two verified reviewers from Aptos Labs.
11. Merge in the change.
12. Announce the update in [See What’s New.](https://aptos.dev/whats-new-in-docs)
13. Monitor builds at: [https://app.netlify.com/sites/aptos-developer-docs/overview](https://app.netlify.com/sites/aptos-developer-docs/overview)
Expand Down

0 comments on commit 9d4dc0e

Please sign in to comment.