[Compiler-v2][trivial] fix error handling for match in expansion ph…

…ase (#15173) * fix * add error only when there isn't one
aptos-labs · Nov 4, 2024 · 5fbf9b7 · 5fbf9b7
1 parent 9baf39b
commit 5fbf9b7
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 5 deletions.
diff --git a/third_party/move/move-compiler-v2/tests/checking/variants/bug_15073.exp b/third_party/move/move-compiler-v2/tests/checking/variants/bug_15073.exp
@@ -0,0 +1,7 @@
+
+Diagnostics:
+error: unbound module
+  ┌─ tests/checking/variants/bug_15073.move:8:13
+  │
+8 │             ToolType::Http { uri } => {
+  │             ^^^^^^^^ Unbound module or type alias 'ToolType'
diff --git a/third_party/move/move-compiler-v2/tests/checking/variants/bug_15073.move b/third_party/move/move-compiler-v2/tests/checking/variants/bug_15073.move
@@ -0,0 +1,14 @@
+module 0x815::m {
+
+    public fun init_registration(
+        creator: &signer,
+        tool_type: ToolType
+    ) {
+        match(tool_type) {
+            ToolType::Http { uri } => {
+
+            },
+        }
+
+    }
+}
diff --git a/third_party/move/move-compiler/src/expansion/translate.rs b/third_party/move/move-compiler/src/expansion/translate.rs
@@ -2600,13 +2600,22 @@ fn exp_(context: &mut Context, sp!(loc, pe_): P::Exp) -> E::Exp {
             let discriminator = exp(context, *pd);
             let match_arms = parms
                 .into_iter()
-                .map(|parm| {
+                .filter_map(|parm| {
                     let loc = parm.loc;
                     let (pbl, pc, pb) = parm.value;
-                    let bind_list = bind_list(context, pbl).expect("bind list always present");
-                    let opt_cond = pc.map(|e| *exp(context, e));
-                    let body = *exp(context, pb);
-                    sp(loc, (bind_list, opt_cond, body))
+                    if let Some(bind_list) = bind_list(context, pbl) {
+                        let opt_cond = pc.map(|e| *exp(context, e));
+                        let body = *exp(context, pb);
+                        Some(sp(loc, (bind_list, opt_cond, body)))
+                    } else {
+                        if !context.env.has_errors() {
+                            context.env.add_diag(diag!(
+                                Syntax::InvalidLValue,
+                                (loc, "bind list cannot be constructed")
+                            ));
+                        }
+                        None
+                    }
                 })
                 .collect::<Vec<_>>();
             EE::Match(discriminator, match_arms)