cleanup info logs (#14555)

aptos-labs · Sep 15, 2024 · 574fa48 · 574fa48
1 parent c5166de
commit 574fa48
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 6 deletions.
diff --git a/consensus/src/liveness/proposal_generator.rs b/consensus/src/liveness/proposal_generator.rs
@@ -29,7 +29,7 @@ use aptos_consensus_types::{
 };
 use aptos_crypto::{hash::CryptoHash, HashValue};
 use aptos_infallible::Mutex;
-use aptos_logger::{error, info, sample, sample::SampleRate, warn};
+use aptos_logger::{error, sample, sample::SampleRate, warn};
 use aptos_types::{on_chain_config::ValidatorTxnConfig, validator_txn::ValidatorTransaction};
 use aptos_validator_transaction_pool as vtxn_pool;
 use futures::future::BoxFuture;
@@ -203,7 +203,7 @@ impl PipelineBackpressureConfig {
                 PROPOSER_ESTIMATED_CALIBRATED_BLOCK_TXNS.observe(calibrated_block_size as f64);
                 // Check if calibrated block size is reduction in size, to turn on backpressure.
                 if max_block_txns > calibrated_block_size {
-                    info!(
+                    warn!(
                         block_execution_times = format!("{:?}", block_execution_times),
                         estimated_calibrated_block_sizes = format!("{:?}", sizes),
                         calibrated_block_size = calibrated_block_size,

diff --git a/consensus/src/pipeline/buffer_manager.rs b/consensus/src/pipeline/buffer_manager.rs
@@ -708,7 +708,7 @@ impl BufferManager {
                 // find the corresponding item
                 let author = vote.author();
                 let commit_info = vote.commit_info().clone();
-                info!("Receive commit vote {} from {}", commit_info, author);
+                trace!("Receive commit vote {} from {}", commit_info, author);
                 let target_block_id = vote.commit_info().id();
                 let current_cursor = self
                     .buffer

diff --git a/consensus/src/round_manager.rs b/consensus/src/round_manager.rs
@@ -1109,11 +1109,19 @@ impl RoundManager {
                     .await?;
             } else {
                 ORDER_VOTE_VERY_OLD.inc();
-                info!(
+                sample!(
+                    SampleRate::Duration(Duration::from_secs(30)),
+                    info!(
+                        "[sampled] Received old order vote. Order vote round: {:?}, Highest ordered round: {:?}",
+                        order_vote_msg.order_vote().ledger_info().round(),
+                        self.block_store.sync_info().highest_ordered_round()
+                    )
+                );
+                debug!(
                     "Received old order vote. Order vote round: {:?}, Highest ordered round: {:?}",
                     order_vote_msg.order_vote().ledger_info().round(),
                     self.block_store.sync_info().highest_ordered_round()
-                );
+                )
             }
         }
         Ok(())

diff --git a/types/src/transaction/use_case.rs b/types/src/transaction/use_case.rs
@@ -18,7 +18,7 @@ impl std::fmt::Debug for UseCaseKey {
 
         match self {
             Platform => write!(f, "PP"),
-            ContractAddress(addr) => write!(f, "c{}", hex::encode_upper(&addr[31..])),
+            ContractAddress(addr) => write!(f, "c{}", hex::encode_upper(&addr[29..])),
             Others => write!(f, "OO"),
         }
     }