addressing comments. removing unnecessary test files (for deleted test)

aptos-labs · Sep 25, 2024 · 3ef1e13 · 3ef1e13
1 parent f856e1f
commit 3ef1e13
Show file tree

Hide file tree

Showing 14 changed files with 7 additions and 132 deletions.
diff --git a/aptos-move/e2e-move-tests/src/lib.rs b/aptos-move/e2e-move-tests/src/lib.rs
@@ -7,7 +7,6 @@ pub mod aptos_governance;
 pub mod harness;
 pub mod resource_groups;
 pub mod stake;
-pub mod transaction_fee;
 
 use anyhow::bail;
 use aptos_framework::{BuildOptions, BuiltPackage, UPGRADE_POLICY_CUSTOM_FIELD};

diff --git a/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/disable_collection/Move.toml b/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/disable_collection/Move.toml
diff --git a/...s-move/e2e-move-tests/src/tests/transaction_fee.data/disable_collection/sources/main.move b/...s-move/e2e-move-tests/src/tests/transaction_fee.data/disable_collection/sources/main.move
diff --git a/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/enable_collection/Move.toml b/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/enable_collection/Move.toml
diff --git a/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/enable_collection/sources/main.move b/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/enable_collection/sources/main.move
diff --git a/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/initialize_collection/Move.toml b/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/initialize_collection/Move.toml
diff --git a/...ove/e2e-move-tests/src/tests/transaction_fee.data/initialize_collection/sources/main.move b/...ove/e2e-move-tests/src/tests/transaction_fee.data/initialize_collection/sources/main.move
diff --git a/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/remove_validator/Move.toml b/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/remove_validator/Move.toml
diff --git a/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/remove_validator/sources/main.move b/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/remove_validator/sources/main.move
diff --git a/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/upgrade_burn_percentage/Move.toml b/aptos-move/e2e-move-tests/src/tests/transaction_fee.data/upgrade_burn_percentage/Move.toml
diff --git a/...e/e2e-move-tests/src/tests/transaction_fee.data/upgrade_burn_percentage/sources/main.move b/...e/e2e-move-tests/src/tests/transaction_fee.data/upgrade_burn_percentage/sources/main.move
diff --git a/aptos-move/e2e-move-tests/src/transaction_fee.rs b/aptos-move/e2e-move-tests/src/transaction_fee.rs
diff --git a/aptos-move/framework/aptos-framework/doc/transaction_fee.md b/aptos-move/framework/aptos-framework/doc/transaction_fee.md
@@ -294,8 +294,7 @@ No longer supported.
 
 ## Function `initialize_fee_collection_and_distribution`
 
-Initializes the resource storing information about gas fees collection and
-distribution. Should be called by on-chain governance.
+DEPRECATED
 
 
 <pre><code>#[deprecated]
@@ -321,10 +320,11 @@ distribution. Should be called by on-chain governance.
 
 ## Function `upgrade_burn_percentage`
 
-Sets the burn percentage for collected fees to a new value. Should be called by on-chain governance.
+DEPRECATED
 
 
-<pre><code><b>public</b> <b>fun</b> <a href="transaction_fee.md#0x1_transaction_fee_upgrade_burn_percentage">upgrade_burn_percentage</a>(_aptos_framework: &<a href="../../aptos-stdlib/../move-stdlib/doc/signer.md#0x1_signer">signer</a>, _new_burn_percentage: u8)
+<pre><code>#[deprecated]
+<b>public</b> <b>fun</b> <a href="transaction_fee.md#0x1_transaction_fee_upgrade_burn_percentage">upgrade_burn_percentage</a>(_aptos_framework: &<a href="../../aptos-stdlib/../move-stdlib/doc/signer.md#0x1_signer">signer</a>, _new_burn_percentage: u8)
 </code></pre>
 
 

diff --git a/aptos-move/framework/aptos-framework/sources/transaction_fee.move b/aptos-move/framework/aptos-framework/sources/transaction_fee.move
@@ -86,13 +86,13 @@ module aptos_framework::transaction_fee {
     }
 
     #[deprecated]
-    /// Initializes the resource storing information about gas fees collection and
-    /// distribution. Should be called by on-chain governance.
+    /// DEPRECATED
     public fun initialize_fee_collection_and_distribution(_aptos_framework: &signer, _burn_percentage: u8) {
         abort error::not_implemented(ENO_LONGER_SUPPORTED)
     }
 
-    /// Sets the burn percentage for collected fees to a new value. Should be called by on-chain governance.
+    #[deprecated]
+    /// DEPRECATED
     public fun upgrade_burn_percentage(
         _aptos_framework: &signer,
         _new_burn_percentage: u8