Fix node compatibility test CI

aptos-labs · Aug 10, 2023 · 2bf1e5a · 2bf1e5a
1 parent 0f2a91f
commit 2bf1e5a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/docker-build-test.yaml b/.github/workflows/docker-build-test.yaml
@@ -23,7 +23,8 @@ name: "Build+Test Docker Images"
 on: # build on main branch OR when a PR is labeled with `CICD:build-images`
   # Allow us to run this specific workflow without a PR
   workflow_dispatch:
-  pull_request_target:
+  # todo undo
+  pull_request:
     types: [labeled, opened, synchronize, reopened, auto_merge_enabled]
   push:
     branches:

diff --git a/.github/workflows/node-api-compatibility-tests.yaml b/.github/workflows/node-api-compatibility-tests.yaml
@@ -114,8 +114,10 @@ jobs:
         if: ${{ !inputs.SKIP_JOB }}
 
       # Ensure any changes to the generated client were checked in.
-      - run: |
-          cd ./ecosystem/typescript/sdk && pnpm generate-client -o /tmp/generated_client
+      - run: cd ./ecosystem/typescript/sdk && pnpm generate-client -o /tmp/generated_client
+        if: ${{ !inputs.SKIP_JOB }}
+
+      - run:
           echo "If this step fails, run the following command locally to fix it:"
           echo "cd ecosystem/typescript/sdk && pnpm generate-client"
           git diff --no-index --ignore-space-at-eol --ignore-blank-lines ./ecosystem/typescript/sdk/src/generated/ /tmp/generated_client/