Fix a bug in pull proofs method

aptos-labs · Jun 15, 2024 · 23567bc · 23567bc
1 parent 5530a29
commit 23567bc
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/consensus/src/quorum_store/utils.rs b/consensus/src/quorum_store/utils.rs
@@ -309,13 +309,15 @@ impl ProofQueue {
                     } else if let Some(Some((proof, insertion_time))) =
                         self.batch_to_proof.get(&sort_key.batch_key)
                     {
-                        cur_bytes += batch.num_bytes();
-                        cur_txns += batch.num_txns();
-                        if cur_bytes > max_bytes || cur_txns > max_txns {
+                        if cur_bytes + batch.num_bytes() > max_bytes
+                            || cur_txns + batch.num_txns() > max_txns
+                        {
                             // Exceeded the limit for requested bytes or number of transactions.
                             full = true;
                             return false;
                         }
+                        cur_bytes += batch.num_bytes();
+                        cur_txns += batch.num_txns();
                         let bucket = proof.gas_bucket_start();
                         ret.push(proof.clone());
                         counters::pos_to_pull(bucket, insertion_time.elapsed().as_secs_f64());