Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COVERAGE: Cleanup files.PublishedStorage after dropping a publish #1382

Closed
wants to merge 1 commit into from

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Oct 23, 2024

After dropping files.PublishedStorage there were some leftovers - empty directory tree. If that directory tree is empty, it is now removed.

Fixes: #198

Fixes #

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

After dropping files.PublishedStorage there were some leftovers -
empty directory tree. If that directory tree is empty, it is now removed.

Fixes: #198
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.91%. Comparing base (0e6f9c3) to head (c8e2198).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
deb/publish.go 63.63% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1382      +/-   ##
==========================================
+ Coverage   74.84%   74.91%   +0.06%     
==========================================
  Files         151      151              
  Lines       17161    17180      +19     
==========================================
+ Hits        12845    12871      +26     
+ Misses       3292     3284       -8     
- Partials     1024     1025       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx closed this Oct 24, 2024
@neolynx neolynx deleted the cleanup-local-tree branch October 24, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aptly leave empty directory structure when droping published repo with prefix
2 participants