-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve/documentation #1359
Open
neolynx
wants to merge
8
commits into
master
Choose a base branch
from
improve/documentation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve/documentation #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1359 +/- ##
==========================================
- Coverage 74.86% 74.85% -0.01%
==========================================
Files 157 157
Lines 18088 18098 +10
==========================================
+ Hits 13541 13547 +6
- Misses 3450 3453 +3
- Partials 1097 1098 +1 ☔ View full report in Codecov by Sentry. |
neolynx
force-pushed
the
improve/documentation
branch
from
October 4, 2024 14:13
80c1b51
to
5156aa0
Compare
neolynx
force-pushed
the
improve/documentation
branch
from
October 5, 2024 16:24
df8a358
to
236e0d6
Compare
neolynx
force-pushed
the
improve/documentation
branch
from
October 5, 2024 17:11
236e0d6
to
092e088
Compare
cfiehe
approved these changes
Oct 5, 2024
neolynx
force-pushed
the
improve/documentation
branch
5 times, most recently
from
October 9, 2024 18:13
f7903cb
to
af56e15
Compare
neolynx
force-pushed
the
improve/documentation
branch
from
October 15, 2024 11:59
af56e15
to
e673378
Compare
neolynx
force-pushed
the
improve/documentation
branch
from
October 22, 2024 18:47
e673378
to
cafd7d0
Compare
- use markdown files in swagger - automate version, use swager.conf template - embed swagger ui index.html as docs.html
neolynx
force-pushed
the
improve/documentation
branch
from
November 1, 2024 20:08
cafd7d0
to
c472fba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Document all APIs with swagger
In order to replace / automate the API documentation on https://www.aptly.info/doc/api document API calls with swagger.
About 40 APIs currently only have stubs and need to be documented:
Run swagger
See Swagger doc: http://localhost:3142/docs
Note: as the dev server has live reload, changes to the code will be recompiled, then the page can be reloaded.
Examples
GET Request: https://github.com/aptly-dev/aptly/blob/improve/documentation/api/mirror.go#L220 (returning object)
GET Request: https://github.com/aptly-dev/aptly/blob/improve/documentation/api/mirror.go#L34 (returning a list)
POST Request: https://github.com/aptly-dev/aptly/blob/improve/documentation/api/mirror.go#L54 (with json body params)
Object: https://github.com/aptly-dev/aptly/blob/improve/documentation/deb/remote.go#L36 (used in response)
Header:https://github.com/aptly-dev/aptly/blob/improve/documentation/api/api.go#L47 (long description with bullet list)
Document aptly.conf
Found that aptly uses
github.com/DisposaBoy/JsonConfigReader
already, tunrs our it supports comments in json,so we can have a inline documented config file.
Checklist