Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom Azure publish endpoint #1063

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

chuan
Copy link
Contributor

@chuan chuan commented Apr 22, 2022

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Add custom endpoint config for publishing to Azure blob storage. This is needed to support publishing to Azure sovereign clouds, i.e. China, Germany, and the US government. The change also made it possible to test the Azure publishing via the Azure storage emulator by setting the endpoint to the local emulator address.

Checklist

  • unit-test added (if change is algorithm)
  • [ ] functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • [ ] bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

Copy link
Contributor

@randombenj randombenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@randombenj randombenj merged commit 152538c into aptly-dev:master Apr 25, 2022
@chuan chuan deleted the azure-endpoint branch April 29, 2022 21:33
@randombenj randombenj added this to the 1.5.0 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants