Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout CI build job after 30 minutes #1033

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Conversation

lbolla
Copy link
Contributor

@lbolla lbolla commented Feb 12, 2022

Fix #1032

Fixes #

Description of the Change

Add a 30 minutes timeout to CI build test, to avoid runaway tests.
Currently sane unittests run in less than 10 minutes.

@ximon18
Copy link
Contributor

ximon18 commented Feb 12, 2022

Looks good. The only thing I don't know is what happens if one of the matrix jobs has to wait for a free hosted runner before it can start - does the 30 minutes apply from the start of each matrix job or is across all matrix jobs and thus ones that started late could get timed out earlier than 30 minutes? I read the docs but didn't find the answer to this. I wondered because if you say sane jobs finish in 10 minutes then maybe 30 minutes is a bit on the high side and could be lower.

@lbolla
Copy link
Contributor Author

lbolla commented Feb 12, 2022

Failing test is caused by linux.del.com being down, which seems usual: https://www.dell.com/community/Systems-Management-General/linux-dell-com-down-or-decomissioned/td-p/7731548

I've opened #1034

Copy link
Contributor

@randombenj randombenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbolla
Copy link
Contributor Author

lbolla commented Feb 13, 2022

Failing test is caused by linux.del.com being down, which seems usual: https://www.dell.com/community/Systems-Management-General/linux-dell-com-down-or-decomissioned/td-p/7731548

I've opened #1034

#1034 is closed. I need to rebase this PR to master and see if tests now pass.

@lbolla lbolla merged commit f89350e into master Feb 13, 2022
@neolynx neolynx deleted the issue-1032-ci-timeouts branch July 3, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding timeouts to CI jobs to avoid runaway tests
3 participants