Grab downloader #1016
Merged
Grab downloader #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"temp" downloader uses its own naming for downloaded files.
Also, update "pkg/errors" library.
We use go modules now.
|
I will add tests for the "grab" downloader, but I would appreciate an early feedback. |
neolynx
approved these changes
Jan 29, 2022
randombenj
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR implements another kind of "downloader" besides the default one based on Go's http standard library. It uses grab which, coupled with the existing retry strategy, is more robust thanks to resumable downloads.
Checklist
AUTHORS