Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Go 1.16 and 1.17 #1012

Closed
lbolla opened this issue Jan 26, 2022 · 2 comments
Closed

Support Go 1.16 and 1.17 #1012

lbolla opened this issue Jan 26, 2022 · 2 comments

Comments

@lbolla
Copy link
Contributor

lbolla commented Jan 26, 2022 •
edited
Loading

Detailed Description

Lints fail for go 1.16 and 1.17.
See https://github.com/aptly-dev/aptly/runs/4950058855?check_suite_focus=true
and https://github.com/aptly-dev/aptly/runs/4950125380?check_suite_focus=true

Possible Implementation

Either ignore the linting warning or consider using another crypto algorightm.
@lbolla lbolla mentioned this issue Jan 26, 2022
Merged
6 tasks
@lbolla lbolla changed the title Support Go 1.17 Support Go 1.16 and 1.17 Jan 26, 2022
@lbolla
Copy link
Contributor Author

lbolla commented Jan 26, 2022

It looks like we use crypto/dsa just for logging purposes: https://github.com/molior-dbs/aptly/blob/molior/pgp/openpgp.go

Maybe silencing the linter is the best option.

lbolla added a commit that referenced this issue Jan 26, 2022
@lbolla
Silence unhelpful linter error
aac176f 
See #1012
randombenj pushed a commit that referenced this issue Jan 26, 2022
@lbolla @randombenj
Silence unhelpful linter error
1d51850 
See #1012
@lbolla
Copy link
Contributor Author

lbolla commented Jan 26, 2022

Linter silenced in aac176f6

@lbolla lbolla closed this as completed Jan 26, 2022
lbolla added a commit that referenced this issue Jan 27, 2022
@lbolla
Silence unhelpful linter error
0dc49d2 
See #1012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lbolla