-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial PR #2
Merged
Merged
Initial PR #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krallin
force-pushed
the
master
branch
2 times, most recently
from
July 11, 2017 10:52
bdb82fb
to
631bf0e
Compare
We need startReaderDrain to add to the WaitGroup before we move on to waiting on it.
krallin
force-pushed
the
master
branch
9 times, most recently
from
July 11, 2017 11:20
f22f593
to
063f2f5
Compare
krallin
force-pushed
the
master
branch
3 times, most recently
from
July 11, 2017 11:32
90ef9e2
to
9a00ee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a bit of work to do here:
SIGTERM
/SIGINT
cron/cron.go:StartJob
(dependent on a having a way to signal it to stop)main.go
USER
declaration (we ignore it)