Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reap zombie process and opt-out with no-reap flag #172

Merged
merged 11 commits into from
Oct 10, 2024
Merged

refactor: reap zombie process and opt-out with no-reap flag #172

merged 11 commits into from
Oct 10, 2024

Conversation

qianlongzt
Copy link
Contributor

fix: #171

close: #136

@qianlongzt qianlongzt changed the title refactor: reaper zombie process and opt in with reap flag refactor: reap zombie process and opt in with reap flag Sep 21, 2024
@UserNotFound UserNotFound removed the request for review from krallin September 23, 2024 18:43
@qianlongzt
Copy link
Contributor Author

@UserNotFound, I fixed the action that was stuck. Please re-run the action

@qianlongzt
Copy link
Contributor Author

@UserNotFound Is there anything I can do? There's no progress.

joshraker
joshraker requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@joshraker joshraker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work you put into this.

main.go Outdated Show resolved Hide resolved
integration/test.bats Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
reaper.go Outdated Show resolved Hide resolved
reaper.go Outdated Show resolved Hide resolved
reaper.go Outdated Show resolved Hide resolved
@qianlongzt qianlongzt changed the title refactor: reap zombie process and opt in with reap flag refactor: reap zombie process and opt-out with no-reap flag Oct 2, 2024
@qianlongzt
Copy link
Contributor Author

@joshraker @UserNotFound Is there anything I can do? There's no progress.

@joshraker joshraker merged commit 8b4edf5 into aptible:master Oct 10, 2024
1 check passed
@atesca09 atesca09 mentioned this pull request Oct 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshraker joshraker joshraker approved these changes

@UserNotFound UserNotFound Awaiting requested review from UserNotFound UserNotFound is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

supercronic logs "error running command: waitid: no child processes" regulary since v0.2.31
2 participants
@qianlongzt @joshraker