Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backup_retention_policy:set attribute handling #339

Merged
merged 11 commits into from
Jun 3, 2024
Merged

Conversation

joshraker
Copy link
Member

@joshraker joshraker commented Jun 3, 2024

Using **options to create a backup retention policy was working but it seems un unexpected dependency change broke it.

Also, overall option usage has changed:

At least one attribute must be specified.

❯ aptible backup_retention_policy:set josh-r-brp
Please specify at least one attribute to change

If the environment does not have a custom backup retention policy, all attributes must be specified.

❯ aptible backup_retention_policy:set josh-r-brp --daily 1 --make-copy
Environemnt josh-r-brp does not have a custom backup retention policy. Please specify all attributes to create one.
❯ aptible backup_retention_policy:set josh-r-brp --daily 3 --monthly 2 --yearly 1 --no-make-copy --keep-final
Id: 6873
Daily: 3
Monthly: 2
Yearly: 1
Make Copy: false
Keep Final: true
Environment: josh-r-brp

Otherwise, only the attributes to be changed need to be specified.

❯ aptible backup_retention_policy:set josh-r-brp --daily 10 --make-copy
Id: 6876
Daily: 10
Monthly: 2
Yearly: 1
Make Copy: true
Keep Final: true
Environment: josh-r-brp

neurosnap
neurosnap previously approved these changes Jun 3, 2024
@joshraker joshraker marked this pull request as draft June 3, 2024 15:51
@joshraker
Copy link
Member Author

@joshraker joshraker marked this pull request as ready for review June 3, 2024 19:25
@joshraker joshraker requested a review from neurosnap June 3, 2024 19:44
@joshraker joshraker merged commit 0e8c61e into master Jun 3, 2024
4 checks passed
@joshraker joshraker deleted the bug-brp-set branch June 3, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants