Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change container scale input to text #958

Merged
merged 1 commit into from
Oct 29, 2024
Merged

change container scale input to text #958

merged 1 commit into from
Oct 29, 2024

Conversation

grrowe
Copy link
Contributor

@grrowe grrowe commented Oct 29, 2024

  • change type to text
  • add pattern and inputMode as well

Reason for fixing
https://www.loom.com/share/c86884c64c324a0fb79f9cfc7455e343?sid=c173aeb2-8c12-470a-bbc8-5797266dc841

Once this is merged and deployed, I will be going back and changing all number inputs to text.

Copy link
Member

@neurosnap neurosnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, looks good!

@grrowe grrowe merged commit 9aeea7a into main Oct 29, 2024
6 checks passed
@grrowe grrowe deleted the remove-number-input branch October 29, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants