Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ids to headings in the pricing page #396

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

christyjacob4
Copy link
Member

What does this PR do?

Add some IDs for easier referencing of certain elements on the pricing page.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Copy link

render bot commented Nov 29, 2023

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 9:19pm

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The navbar covers up part of content when you're taken to the fragment. For example, browsing to #open-source-teams results in:

image image

Not sure what we can do about it, though 😕

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The navbar doesn't cover the content now:

image

👍🏼

@christyjacob4 christyjacob4 merged commit ffea290 into main Nov 29, 2023
3 checks passed
@christyjacob4 christyjacob4 deleted the add-ids-for-pricing branch November 29, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants