Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add skip to content link #359

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

ketanbaitule
Copy link
Contributor

What does this PR do?

Add Skip To Content Link

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

Solves #278

Have you read the Contributing Guidelines on issues?

Yes

Copy link

vercel bot commented Nov 18, 2023

@ketanbaitule is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@ketanbaitule
Copy link
Contributor Author

Screencast.from.2023-11-18.15-45-45.webm

Copy link
Contributor

@TGlide TGlide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I left some comments, and also let our design team know about this so they can review it.

@@ -127,7 +127,7 @@
<meta name="twitter:card" content="summary_large_image" />
</svelte:head>

<main class="aw-main-section">
<main class="aw-main-section" id="main">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding it to pages alone won't be enough, we should add them to all relevant layouts

position: absolute;
top: 0;
-webkit-transform: translateY(-999px);
transform: translateY(-999px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to use opacity instead of translations?

@ariascaio
Copy link

@ketanbaitule I'm a member of the Design team at Appwrite :)
I did a few adjustments to the Skip to Content banner for you to implement, you can check it on Figma

@TGlide TGlide merged commit 7508885 into appwrite:main Dec 18, 2023
0 of 2 checks passed
@ketanbaitule
Copy link
Contributor Author

@TGlide Hi I have not completed it due to my exams. I guess you have mistakenly merged it

@TGlide
Copy link
Contributor

TGlide commented Dec 19, 2023

@TGlide Hi I have not completed it due to my exams. I guess you have mistakenly merged it

I've made some commits on top of your work before merging it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants