Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init playground #1180

Merged
merged 30 commits into from
Aug 7, 2024
Merged

Init playground #1180

merged 30 commits into from
Aug 7, 2024

Conversation

thejessewinton
Copy link
Contributor

@thejessewinton thejessewinton commented Aug 6, 2024 •
edited
Loading

What does this PR do?

Downgrade's sharp per this issue. This should fix the OG image.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@thejessewinton thejessewinton marked this pull request as ready for review August 6, 2024 19:35
@stnguyen90 stnguyen90 self-requested a review August 6, 2024 22:50
stnguyen90
stnguyen90 reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little concerned about the failed build. When I run the following locally:

git checkout init-playground
pnpm install --frozen-lockfile
NODE_OPTIONS=--max_old_space_size=8192 pnpm run build

I also get errors:

image

@TorstenDittmann TorstenDittmann merged commit 5f5cbca into main Aug 7, 2024
1 check passed
@TorstenDittmann TorstenDittmann deleted the init-playground branch August 7, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thejessewinton @stnguyen90 @TorstenDittmann