Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add push-notification-with-fcm template in TypeScript #255

Closed
wants to merge 5 commits into from
Closed

feat: add push-notification-with-fcm template in TypeScript #255

wants to merge 5 commits into from

Conversation

priyanshuverma-dev
Copy link

What does this PR do?

This PR adds new template for Push Notification with FCM in TypeScript.

Test Plan

  1. I have deployed this Function and checked that iit is working fine.
  2. below is the demo of my work.
Functions.-.Appwrite.-.Google.Chrome.mp4

Related PRs and Issues

The issue this PR solves is #253

Have you read the Contributing Guidelines on issues?

Yes, I have read the instructions on issue #253

@priyanshuverma-dev
Copy link
Author

@Haimantika @loks0n Please review pull request!

loks0n
loks0n requested changes Nov 23, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
loks0n
loks0n requested changes Nov 23, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
Meldiron
Meldiron requested changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great! 🔥 Left a few comments. Once addressed, I can mark it approved.

@loks0n We can ignore README changes, they will get overwritten anyway after merge.

priyanshuverma-dev
priyanshuverma-dev commented Nov 24, 2023
View reviewed changes
Copy link
Author

@priyanshuverma-dev priyanshuverma-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to do less changes and wrote this code as similar to node. if do futher improvement like node then it will give types errors. Please support and inform me next.

node-typescript/push-notification-with-fcm/src/main.ts Show resolved Hide resolved
node-typescript/push-notification-with-fcm/src/utils.ts Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
@priyanshuverma-dev priyanshuverma-dev closed this by deleting the head repository Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loks0n loks0n Awaiting requested review from loks0n

@Meldiron Meldiron Awaiting requested review from Meldiron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priyanshuverma-dev @Meldiron @loks0n