Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat CLI pagination #739

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Feat CLI pagination #739

merged 2 commits into from
Nov 20, 2023

Conversation

abnegate
Copy link
Contributor

@abnegate abnegate commented Nov 6, 2023

What does this PR do?

  • Add scaling timeout for attribute/index create/delete
  • Add pagination

Test Plan

Manual test + existing tests

Related PRs and Issues

appwrite/sdk-for-cli#135

Have you read the Contributing Guidelines on issues?

Yes

Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you share screenshot of how this works in action? @abnegate

@tripolskypetr
Copy link

@abnegate @lohanidamodar Guys what the status of that bug? Looks like this MR approved but It stuck in daily routine

@abnegate
Copy link
Contributor Author

@lohanidamodar
Screenshot 2023-11-15 at 17 05 06

@tripolskypetr Almost there 😁

@lohanidamodar
Copy link
Member

LGTM

@abnegate abnegate merged commit 3a10f1f into master Nov 20, 2023
36 checks passed
@abnegate abnegate deleted the feat-cli-bulk-deploy branch November 20, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants