-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add path keyword #614
Conversation
…to feat-add-path-keyword
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Meldiron Please add it to only relevant languages and also add it to abstract public function getIdentifierOverrides(): array;
or the relevant language to give it a proper replacement like urlPath
or similar.
Converting to draft. Will become relevant again near internal Functions G4 testing |
@Meldiron can you also add this to identifier overrides so that we can have a override sucha as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good to merge, my last comment as I discussed with matej, as path can refer to file path, code path or something else, there is no proper identifier override that we can manually do so xpath
is okay for now
What does this PR do?
We use
path
as variable name inside function. Such parameter cannot be provided, otherwise there will be an error likeTest Plan
Related PRs and Issues
x
Have you read the Contributing Guidelines on issues?
Yes