Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix between query output #63

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Fix between query output #63

merged 2 commits into from
Nov 20, 2023

Conversation

abnegate
Copy link
Contributor

What does this PR do?

  • Fix between query output
  • Fix self-signed warnings
  • Fix typing for Role.label

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Comment on lines +206 to +217
async getQueueDeletes(threshold) {
const apiPath = '/health/queue/deletes';
let payload = {};

if (typeof threshold !== 'undefined') {
payload['threshold'] = threshold;
}

return await this.client.call('get', apiPath, {
'content-type': 'application/json',
}, payload);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure these should be part of this PR. if yes, we've to make this a minor version

@abnegate abnegate merged commit 3e4e6ce into main Nov 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants