-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug(cli): code.tar.gz file remains after error occurs #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, could you please clean up the commit and remove all the unnecessary white space type changes so we can find what changed more easily?
Sure. |
@@ -405,6 +405,7 @@ const functionsCreateDeployment = async ({ functionId, code, activate, entrypoin | |||
/* @param {string} entrypoint */ | |||
/* @param {string} commands */ | |||
|
|||
try{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Let's not have such a big try/catch
- This repo is read-only and the change should be done with the sdk-generator repo.
I'm going to add the hacktoberfest-accepted label just so you get credit, but we'll probably close this PR since we need the change in the SDK generator repo. |
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
closing as change needs to be done in sdk-generator repo. |
What does this PR do?
Test Plan
N/A
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes