Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Filters to not allow filtering on all columns #654

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Update Filters to not allow filtering on all columns #654

merged 8 commits into from
Jan 2, 2024

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Dec 14, 2023 •
edited
Loading

What does this PR do?

  • Create a component to handle 0 results from filtering
  • Update filterable columns on subscribers table

Test Plan

Manual

Related PRs and Issues

Parent:

Child:

Have you read the Contributing Guidelines on issues?

Yes

@vercel Vercel
Copy link

vercel bot commented Dec 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 2:31pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 2:31pm
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 2:31pm

@stnguyen90 stnguyen90 mentioned this pull request Dec 14, 2023
Merged
@stnguyen90 stnguyen90 changed the base branch from main to feat-messaging-push-preview December 14, 2023 21:06
@stnguyen90 stnguyen90 mentioned this pull request Dec 14, 2023
Merged
@stnguyen90 stnguyen90 force-pushed the feat-messaging-push-preview branch from 632fa84 to ed69b25 Compare December 14, 2023 23:35
@stnguyen90 stnguyen90 force-pushed the feat-messaging-push-preview branch from ed69b25 to 40a9ec6 Compare December 15, 2023 20:04
@stnguyen90 stnguyen90 force-pushed the feat-messaging-push-preview branch from 40a9ec6 to 5581914 Compare December 19, 2023 22:48
@stnguyen90 stnguyen90 mentioned this pull request Dec 19, 2023
Merged
@stnguyen90 stnguyen90 force-pushed the feat-messaging-push-preview branch from 5581914 to 48babe9 Compare December 20, 2023 01:59
@stnguyen90
Fix alignment of create message/provider dropdowns
c130820 
The right side of the droplist should align with the right side of the button.
@stnguyen90
Fix the order create message/provider drop items
81ddc61
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
@TorstenDittmann
Merge pull request #665 from appwrite/fix-messaging-design-review
8008e58 
Fix messaging based on design review feedback
@TorstenDittmann TorstenDittmann merged commit 8530a2a into feat-messaging-push-preview Jan 2, 2024
4 checks passed
@TorstenDittmann TorstenDittmann deleted the feat-filters branch January 2, 2024 14:40
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stnguyen90 @TorstenDittmann