Fix the allowed extensions for uploading .env files #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think we should just allow all extensions. There is also cases of .env.production and co. |
Remove the file extension restriction because it can be named anything including .env.local, .env.production, etc.
stnguyen90
force-pushed
the
fix-env-upload-allowed-extensions
branch
from
3caf93f to
02df554
Compare
eldadfux
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It should not include the leading dot because the InputFile component adds the leading prefix so including the leading dot results in an extra dot like:
Test Plan
Before the change, .env files were not selectable:
and trying to drag a .env file into the modal results in:
After the change, I can now select any file including .env files.
Related PRs and Issues
None
Have you read the Contributing Guidelines on issues?
Yes