-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Added Rebuild button for function view when build fails during deployment #376
Fix: Added Rebuild button for function view when build fails during deployment #376
Conversation
@singhbhaskar is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Good idea on the confirmation modal too! I just have some minor text suggestions.
src/routes/console/project-[project]/functions/function-[function]/+page.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/functions/function-[function]/rebuild.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/functions/function-[function]/rebuild.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/functions/function-[function]/rebuild.svelte
Outdated
Show resolved
Hide resolved
Sure Steven, I'll update the suggest changes. Thanks |
src/routes/console/project-[project]/functions/function-[function]/+page.svelte
Outdated
Show resolved
Hide resolved
build fails during deployment.
75cca9d
to
2120d77
Compare
Hi @stnguyen90 , Screenshot for function failure:Screenshot for Model Alert when user clicks on rebuild button:Screenshot for Notification alert when rebuild request is process by the SDK: |
@singhbhaskar looks like the tests are failing. Perhaps the package name has changed? Also, please make sure to re-request a review when you're ready for a review. |
@aw-labs/appwrite-console to @appwrite.io/console for rebuild.svelte
Hi @stnguyen90 , |
src/routes/console/project-[project]/functions/function-[function]/rebuild.svelte
Outdated
Show resolved
Hide resolved
I am able to successfully run lint and test in my local system but for some reason it's failing during the check. Can you trigger a rebuild? |
@TorstenDittmann, I also tried to check the linting and it seems fine. I manually ran the tests and they all passed: I can confirm the modal triggers a new build: What do you think about just merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once you have fixed the formatting issues we can merge 👍🏻
just run npm run format
Hi, |
…ow-retrying-failed-builds
What does this PR do?
Adds a new button to rebuild function deployment if it fails. The button is not showed when the build is successfull.
Test Plan
Mannual testing. Ran
npm run build
,npm run format
andnpm run lint
. Attaching the screenshot for the following test.Screenshot for function failure:
Screenshot for Model Alert when user clicks on rebuild button:
Screenshot for Notification alert when rebuild request is process by the SDK:
Screenshot for Successful function build which doesn't show the rebuild option.
Related PRs and Issues
appwrite/appwrite#4840
Have you read the Contributing Guidelines on issues?
Yes I have read the contributing guidelines.