Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prefs empty array case #1518

Merged
merged 5 commits into from
Nov 15, 2024
Merged

fix: prefs empty array case #1518

merged 5 commits into from
Nov 15, 2024

Conversation

TorstenDittmann
Copy link
Contributor

@TorstenDittmann TorstenDittmann commented Nov 15, 2024 •
edited
Loading

What does this PR do?

  • fallback check to account for an empty array being returned was not accessiing possible null values correctly

Test Plan

  • manual

Have you read the Contributing Guidelines on issues?

✅

@stnguyen90 stnguyen90 merged commit 9565113 into main Nov 15, 2024
2 checks passed
@TorstenDittmann TorstenDittmann deleted the fix-prefs-empty-case branch November 15, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@eldadfux eldadfux eldadfux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TorstenDittmann @eldadfux @stnguyen90