Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration feedback form 400 #1492

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Fix migration feedback form 400 #1492

merged 4 commits into from
Nov 7, 2024

Conversation

ernstmul
Copy link
Contributor

@ernstmul ernstmul commented Nov 6, 2024

What does this PR do?

Add fallback value so form submit doesn't result in 400 error

Have you read the Contributing Guidelines on issues?

@ernstmul ernstmul requested a review from stnguyen90 November 6, 2024 09:51
@stnguyen90
Copy link
Contributor

Approved but the failed E2E worries me a little bit

@ernstmul ernstmul requested a review from stnguyen90 November 7, 2024 10:18
@ernstmul
Copy link
Contributor Author

ernstmul commented Nov 7, 2024

Approved but the failed E2E worries me a little bit

@stnguyen90 Was caused by an invalid cert on the test api. That's fixed now, and the tests are green again!

@ernstmul ernstmul merged commit 9a2a946 into main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants