Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix billing estimate loader #1490

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Fix billing estimate loader #1490

merged 7 commits into from
Nov 8, 2024

Conversation

ernstmul
Copy link
Contributor

@ernstmul ernstmul commented Nov 4, 2024

What does this PR do?

Introduce loader until all data is loaded

Screen.Recording.2024-11-04.at.10.48.19.mov

Have you read the Contributing Guidelines on issues?

@stnguyen90 stnguyen90 self-requested a review November 4, 2024 21:06
@ernstmul ernstmul requested a review from stnguyen90 November 5, 2024 09:39
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts 😭

# Conflicts:
#	src/routes/(console)/organization-[organization]/billing/planSummary.svelte
@stnguyen90 stnguyen90 merged commit edaae31 into main Nov 8, 2024
2 checks passed
@stnguyen90 stnguyen90 deleted the fix-billing-estimate-loader branch November 8, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants