Add support for multiple events per endpoint #5703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
commented
Jun 14, 2023
| @@ -79,12 +79,16 @@ function createAttribute(string $databaseId, string $collectionId, Document $att | |||
| throw new Exception(Exception::DATABASE_NOT_FOUND); | |||
| } | |||
|
|
|||
| $events->setContext('database', $db); | |||
There was a problem hiding this comment.
This context is required by some events so we have to make sure to set it before the DB operation so it's available in the handler.
stnguyen90
commented
Jun 14, 2023
Comment on lines
+706
to
+708
| $events->setContext('token', new Document([ | ||
| 'secret' => $loginSecret, | ||
| ])); |
There was a problem hiding this comment.
The unhashed secret is required in the event, so pass it to the handler using context.
stnguyen90
commented
Jun 14, 2023
app/init.php
Outdated
Comment on lines
1220
to
1233
| switch ($collection) { | ||
| case 'users': | ||
| if (!\str_starts_with($eventPattern, 'users.[userId]')) { | ||
| $eventPattern = 'users.[userId]'; | ||
| $eventPatternReady = false; | ||
| } |
There was a problem hiding this comment.
reverse engineering the event pattern given the collection feels a little hacky.
stnguyen90
commented
Jun 14, 2023
| @@ -219,7 +219,7 @@ | |||
| ->setAttribute('password', Auth::passwordHash($password, Auth::DEFAULT_ALGO, Auth::DEFAULT_ALGO_OPTIONS)) | |||
| ->setAttribute('hash', Auth::DEFAULT_ALGO) | |||
| ->setAttribute('hashOptions', Auth::DEFAULT_ALGO_OPTIONS); | |||
| $dbForProject->updateDocument('users', $profile->getId(), $profile); | |||
| $dbForProject->silent(fn () => $dbForProject->updateDocument('users', $profile->getId(), $profile)); | |||
There was a problem hiding this comment.
Wrapping with silent to disable all listeners might be dangerous.
stnguyen90
force-pushed
the
feat-2406-multiple-events
branch
2 times, most recently
from
1ea5e58 to
138856f
Compare
We initially designed events to trigger via labels on the endpoint. the problem with this approach was triggering multiple events per endpoint became very messy.
stnguyen90
force-pushed
the
feat-2406-multiple-events
branch
from
138856f to
bcb6b30
Compare
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Trigger events using database listeners
We initially designed events to trigger via labels on the endpoint. the problem with this approach was triggering multiple events per endpoint became very messy.
Test Plan
TBD
Related PRs and Issues
users.*.createwhen an Anonymous user is created #5198Checklist