Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TypeScript 5.6.3 #523

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Update to TypeScript 5.6.3 #523

wants to merge 2 commits into from

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Nov 7, 2024

Minimal reproduction of an eslint issue when updating to TypeScript 5.6.3.

Current config that breaks:

import ts from 'typescript-eslint';
import ember from 'eslint-plugin-ember/recommended';

const parserOptions = {
  esm: {
    ts: {
      projectService: true,
      tsconfigRootDir: import.meta.dirname,
    },
  },
};

export default ts.config(
  {
    ignores: ['**/*.js', '**/*.mjs'],
  },
  {
    name: 'ts',
    files: ['**/*.ts'],
    languageOptions: {
      // Uncommenting this fixes the issue so it seems to be related to switching parsers for different kinds of typed files?
      // parser: ember.parser,
      parserOptions: parserOptions.esm.ts,
    },
    extends: [...ts.configs.recommendedTypeChecked],
    // extends: [...ts.configs.recommended], // also fails
  },
  {
    name: 'gts',
    files: ['**/*.gts'],
    languageOptions: {
      parser: ember.parser,
      parserOptions: parserOptions.esm.ts,
    },
    // These don't really matter, commented or not, it fails
    // extends: [...ts.configs.recommendedTypeChecked, ember.configs.gts],
  },
);

This strips everything that isn't needed while still showing the error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant